Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add German HOWTO file #5684

Closed
wants to merge 17 commits into from
Closed

Add German HOWTO file #5684

wants to merge 17 commits into from

Conversation

Squirkyy
Copy link
Contributor

@Squirkyy Squirkyy commented Oct 1, 2021

What does this PR do?

Add ONE HOWTO file (german) + ONE CODEOFCONDUCT file (german) and changes EIGHT HOWTO files

For resources

Description

I added a German Translation for the HOWTO file and added the option to switch to German in all the other files.
I also added the German Translation for the Code of Conduct.

Why is this valuable (or not)?

It helps the German learning community.

Checklist:

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@Squirkyy Squirkyy changed the title Add German Add German HOWTO file Oct 1, 2021
@eshellman
Copy link
Collaborator

Thanks, and welcome to free-programming-books!

@eshellman
Copy link
Collaborator

please resolve conflicts.

@eshellman eshellman added the conflicts Conflict(s) need to be resolved label Oct 1, 2021
@davorpa davorpa self-requested a review October 2, 2021 01:42
@davorpa davorpa added waiting for changes PR has been reviewed and changes/suggestions requested New Feature New feature / enhancement / translation... labels Oct 2, 2021
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback and changes:

  • Conficts are due to recent added russian HOWTO HOWTO in Russian #5669 . The new text was added at the end on paragraph like you are also doing. Leave your link at the end, I'm coordinating the other translation in progress

CODE_OF_CONDUCT-de.md Outdated Show resolved Hide resolved
HOWTO-de.md Outdated
@@ -0,0 +1,17 @@
Lese das hier auch in anderen Sprachen: [English](HOWTO.md), [Français](HOWTO-fr.md), [简体中文](HOWTO-zh.md), [हिन्दी](HOWTO-hi.md), [繁體中文](HOWTO-zh_TW.md), [Português (BR)](HOWTO-pt_BR.md) [Español](HOWTO-es.md), [فارسی](HOWTO-fa_IR.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, mantain the same order of items like you can see in other HOWTOs. It contributes to have a good UX.

[Français](HOWTO-fr.md), [Español](HOWTO-es.md), [简体中文](HOWTO-zh.md), [हिन्दी](HOWTO-hi.md), [繁體中文](HOWTO-zh_TW.md), [Português (BR)](HOWTO-pt_BR.md), [فارسی](HOWTO-fa_IR.md).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it! :)

HOWTO-de.md Show resolved Hide resolved
@davorpa davorpa mentioned this pull request Oct 2, 2021
2 tasks
HOWTO-de.md Outdated

Selbst wenn du ein erfahrener Open-Source-Mitwirkender sind, gibt es Dinge, die dich ins Straucheln bringen könnten. Sobald du deinen PR eingereicht hast, führt GitHub Actions einen Linter aus und findet oft kleine Probleme von Absätzen oder Alphabetisierung. Wenn du eine grüne Schaltfläche erhältst, ist alles zur Überprüfung bereit, aber wenn das nicht so ist, klick unter dem fehlgeschlagenen Häkchen auf "Details", um herauszufinden, was dem Linter nicht gefallen hat. Behebe das Problem und füge deinen PR einen Commit hinzu.

Wenn du dir nicht sicher bist, ob die Ressource, die du hinzufügen möchtest, für Free-Programming-Books geeignet ist, lese die Richtlinien in [CONTRIBUTING](CONTRIBUTING.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be coordinated with @lupinitylabs in their translation (see #5720) ... it's safe change crosslink to [CONTRIBUTING](CONTRIBUTING-de.md) too 😉

Wenn du dir nicht sicher bist, ob die Ressource, die du hinzufügen möchtest, für Free-Programming-Books geeignet ist, lese die Richtlinien in [CONTRIBUTING](CONTRIBUTING-de.md).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited it!

@Squirkyy
Copy link
Contributor Author

Squirkyy commented Oct 2, 2021

I changed everything you have mentioned. Anything else that needs changing? @davorpa

@davorpa davorpa removed the conflicts Conflict(s) need to be resolved label Oct 2, 2021
@davorpa davorpa self-requested a review October 2, 2021 18:09
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed everything you have mentioned. Anything else that needs changing?

It seems that all other HOWTO files was lost 😟 on resync upstream. SHAs:

❓ Do you know how to deal with? Maybe do some cherry picks from your firsts pushed commits 🤔

@davorpa davorpa added the conflicts Conflict(s) need to be resolved label Oct 2, 2021
@eshellman
Copy link
Collaborator

looks like you added inadvertent punctuation - look at diffs

@Squirkyy
Copy link
Contributor Author

Squirkyy commented Oct 3, 2021

I think I'll just fork the repo again and commit another PR. Its probably easier and faster

@Squirkyy Squirkyy closed this Oct 3, 2021
@davorpa
Copy link
Member

davorpa commented Oct 3, 2021

Work moved to #5819

@davorpa davorpa added 🗣️ translations Issues or PRs addresing translations 🗣️ locale:de Resources addressing "German / Deutsch" language labels Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Conflict(s) need to be resolved New Feature New feature / enhancement / translation... 🗣️ locale:de Resources addressing "German / Deutsch" language 🗣️ translations Issues or PRs addresing translations waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants