Tests : fix entity row selector #5884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yalit regarding your question, I'd prefer to not use UUIDs in the test application. I mean, adding some UUID property somewhere or even an entire new entity with a UUID as its primary key is OK ... but I'd prefer to not use UUIDs in all the entities of the test app. Thanks! |
|
@javiereguiluz thanks for the answer. |
javiereguiluz
force-pushed
the
fix/fix-entity-row-selector
branch
from
e3cf0f2 to
7be88d4
Compare
|
This is finally merged! Yannick, I'm sorry it took me so long to merge it. Thanks! |
|
@javiereguiluz thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found in the Tests implementation an issue when using ids as UUid : the getIndexEntityRowSelector from the CrudTestSelectors was not working correctly.
There is no entity in the TestApplication with UUids to be able to test. If ok, I can add one entity with UUid as id to the Test Application just for the sake of testing it @javiereguiluz ok to leave it like that or shall I update the TestApplication?