Skip to content

Commit

Permalink
bug #5884 Tests : fix entity row selector (yalit)
Browse files Browse the repository at this point in the history
This PR was squashed before being merged into the 4.x branch.

Discussion
----------

Tests : fix entity row selector

I found in the Tests implementation an issue when using ids as UUid : the getIndexEntityRowSelector from the CrudTestSelectors was not working correctly.

There is no entity in the TestApplication with UUids to be able to test. If ok, I can add one entity with UUid as id to the Test Application just for the sake of testing it `@javiereguiluz` ok to leave it like that or shall I update the TestApplication?

Commits
-------

7be88d4 Tests : fix entity row selector
  • Loading branch information
javiereguiluz committed Oct 23, 2023
2 parents 3b7e8c4 + 7be88d4 commit f9a73a7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Test/Trait/CrudTestSelectors.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ protected function getIndexEntityActionSelector(string $action, string|int $enti

protected function getIndexEntityRowSelector(string|int $entityId): string
{
return sprintf('tbody tr[data-id=%s]', (string) $entityId);
return sprintf('tbody tr[data-id="%s"]', (string) $entityId);
}

protected function getActionSelector(string $action): string
Expand Down

0 comments on commit f9a73a7

Please sign in to comment.