Wait for async migrations upon extension initialization #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostwords
added a commit
that referenced
this pull request
May 12, 2020
Until #2604 gets merged in.
ghostwords
force-pushed
the
wait-for-widgets-and-migrations
branch
2 times, most recently
from
f07b883
to
0276874
Compare
ghostwords
changed the title
ghostwords
force-pushed
the
wait-for-widgets-and-migrations
branch
from
e299097
to
164d78a
Compare
Added to patch data in 2016 after PSL domains weren't getting cookieblocked even though their eTLD was on the yellowlist. #841 Since we've been running data migrations for new installs, has since been obscuring various other yellowlist bugs. Should now be unnecessary following fixes in 1bf6653 and 7680ea5 This is a step towards no longer running migrations for new installs.
ghostwords
force-pushed
the
wait-for-widgets-and-migrations
branch
from
164d78a
to
581fb5c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #2438 by gating remaining asynchronous initialization tasks behind
badger.INITIALIZED.May help avoid test failures like https://travis-ci.org/github/EFForg/privacybadger/jobs/684005771 where for some reason we don't have anything in(waiting on widget initialization happened in c8313e4)tabData.originsat the timegetWidgetList()is called. While this problem seems related to async migrations, it's not yet clear what it is exactly. It is consistently reproducible with Firefox 52 (the previous ESR version) though. Since this issue only manifests immediately following Badger initialization (waiting two seconds avoids it), it doesn't seem to be a release blocker.Should help categorically avoid bugs like #2537, where there is a race condition between two migrations or between a migration and the rest of Privacy Badger.
We should also stop running migrations upon installation.