Clean up migrations #2887
Merged
Clean up migrations #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was added to patch data in 2016 after PSL domains weren't getting cookieblocked even though their eTLD was on the yellowlist: #841 Since we run migrations for new installs, this migration has been obscuring various yellowlist bugs. Should now be unnecessary following fixes in 1bf6653 and 7680ea5.
It's been out since 2022.9.27; affected users should be migrated by now.
All should be obsolete by now.
Instead of on every extension startup. This should be a no-op in functionality as before this change all migrations (except for the one blanked out in f7dc512) ran before seed data was ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #2438.
Replaces #2604. Unlike that PR this does not add handling for async migrations; that can come later, as needed.