Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create adaptation runner #634

Merged
merged 13 commits into from
Dec 10, 2024
Merged

feat: Create adaptation runner #634

merged 13 commits into from
Dec 10, 2024

Conversation

Carsopre
Copy link
Collaborator

@Carsopre Carsopre commented Dec 9, 2024 •
edited
Loading

Issue addressed

Solves #625

Code of conduct

  • I HAVE NOT added sensitive or compromised (test) data to the repository.
  • I HAVE NOT added vulnerabilities to the repository.
  • I HAVE discussed my solution with (other) members of the RA2CE team.

What has been done?

  • Adapted runner to inherit from a base SimpleAnalysisRunnerBase to reduce code duplication.
  • AnalysisFactoryRunner can now run all available analyses in a provide configuration.
  • New AdaptationAnalysisRunner for adaptation analyses.

Checklist

  • Code is formatted using our custom black and isort definitions.
  • Tests are either added or updated.
  • Branch is up to date with master.
  • Updated documentation if needed.

Additional Notes (optional)

Refactoring was required to reduce code duplication and improve how we interact with the tools. The goal is to provide a clear workflow from the handler at the same time that we expose enough (clear) mechanisms for sandboxing.

@Carsopre Carsopre linked an issue Dec 9, 2024 that may be closed by this pull request
Adaptation: create a runner supporting adaptation workflow #625
Closed
@Carsopre Carsopre marked this pull request as ready for review December 9, 2024 15:06
ArdtK
ArdtK approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@ArdtK ArdtK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions

ra2ce/runners/adaptation_analysis_runner.py Show resolved Hide resolved
ra2ce/analysis/analysis_collection.py Outdated Show resolved Hide resolved
tests/runners/test_adaptation_analysis_runner.py Show resolved Hide resolved
@Carsopre Carsopre merged commit eacc8f1 into master Dec 10, 2024
0 of 2 checks passed
@Carsopre Carsopre deleted the feat/625-adaptation-create-a-runner-supporting-adaptation-workflow branch December 10, 2024 09:15
@ArdtK ArdtK mentioned this pull request Dec 10, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArdtK ArdtK ArdtK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adaptation: create a runner supporting adaptation workflow
2 participants
@Carsopre @ArdtK