Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/618 adaptation add option to adaptation config to calculate cost based on fraction segment exposed #639

Conversation

ArdtK
Copy link
Contributor

@ArdtK ArdtK commented Dec 9, 2024

Issue addressed

Solves #618

Code of conduct

  • I HAVE NOT added sensitive or compromised (test) data to the repository.
  • I HAVE NOT added vulnerabilities to the repository.
  • I HAVE discussed my solution with (other) members of the RA2CE team.

What has been done?

  • Add bool hazard_fraction_cost to AnalysisSectionAdaptation
  • Add extra step to cost calulation based on this setting
  • Fix an issue introduced by feat: Create adaptation runner #634 (origin_destinations.py)

Checklist

  • Code is formatted using our custom black and isort definitions.
  • Tests are either added or updated.
  • Branch is up to date with master.
  • Updated documentation if needed.

Additional Notes (optional)

Note the solution is simplified compared to specs after alignment with Matthias.

@ArdtK ArdtK marked this pull request as ready for review December 9, 2024 15:41
Copy link
Collaborator

@Carsopre Carsopre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved under the assumption that it's updated with latest changes of master and has a green TC status.

@MatthiasHauthDeltares
Copy link
Contributor

LGTM

ArdtK and others added 3 commits December 10, 2024 11:16
…on-config-to-calculate-cost-based-on-fraction-segment-exposed
…on-config-to-calculate-cost-based-on-fraction-segment-exposed
@ArdtK ArdtK merged commit 180038f into master Dec 10, 2024
1 check was pending
@ArdtK ArdtK deleted the feat/618-adaptation-add-option-to-adaptation-config-to-calculate-cost-based-on-fraction-segment-exposed branch December 10, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adaptation: add option to Adaptation config to calculate cost based on fraction segment exposed
3 participants