fixes and cleanup for bibchecker #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@paxtonfitzpatrick this looks great! can you check the comment i added to verify that it's correct? it looks like the parentheses/curly braces don't quite match, but i'm not sure if it's a hack to get the checker to pass that entry
| date-modified = {2021-10-26 21:34:02 -0400}, | ||
| journal = {{IEEE} {Xplore}}, | ||
| pages = {doi.org/10.1109/BHI.2017.7897288}, | ||
| booktitle = {2017 {IEEE} {EMBS} International Conference on Biomedical \& Health Informatics {(BHI})}, |
There was a problem hiding this comment.
is the {(BHI}) part correct?
There was a problem hiding this comment.
it's "correct" in that it passses the checker -- I opened #53 about this.
I agree that I'd expect it to be ({BHI}) instead, and the checker should probably be fixed to accept this, but since the difference shouldn't actually affect the output, I went ahead and formatted as the checker wanted for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of citation keys added (one per line)
List of citation keys modified (one per line)
American->{American})A->{A},Bayesian->{Bayesian})force = {True})Other changes (describe)