-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Denylist reload #101
Draft
macfarla
wants to merge
13
commits into
Consensys:main
Choose a base branch
from
macfarla:denylist-reload
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+160
−2
Draft
Denylist reload #101
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a25f5bb
draft
macfarla 4196abe
draft
macfarla 188cd89
draft implementation of reload
macfarla 3e6178f
cleanup
macfarla f74742d
Merge branch 'main' of github.com:Consensys/linea-sequencer into deny…
macfarla 7971dc2
formatting
macfarla 7546f24
Merge branch 'main' of github.com:Consensys/linea-sequencer into deny…
macfarla 8182b42
test passes
macfarla 5d21427
enable plugins api group
macfarla 8f77454
plugin name
macfarla 20389b8
cherry-pick 0fe75ca5 for plugin name change
macfarla 0414f94
merge main
macfarla b84653f
merge
macfarla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
merge main
Signed-off-by: Sally MacFarlane <[email protected]>
commit 0414f94d5b88c6bd57c2ee3acf84a299153a1e11
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to look at rejectedTxJsonRpcManager - may need to do something different with that re start/stop lifecycle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
factory
field inTransactionPoolValidatorServiceImpl
is notvolatile
so the change could not be seen immediately by all thread, said that I prefer that the registration is done one, and the reload only updates the deny list, so for example restricting the moving pieces to a wrap of the deny list in a mutable container that is set at startup and updated on every reload, without having to redo all the initialization of the plugin