Denylist reload #101
Denylist reload #101
Conversation
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
| log.info( | ||
| "Registering Linea plugin of type {} with name {}", | ||
| this.getClass().getName(), | ||
| this.getName()); |
There was a problem hiding this comment.
if plugin name == class name this extra logging may not be useful
| @@ -124,6 +122,12 @@ public void start() { | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public CompletableFuture<Void> reloadConfiguration() { | |||
| loadDenyListAndRegisterPluginTxValidatorFactory(); | |||
There was a problem hiding this comment.
need to look at rejectedTxJsonRpcManager - may need to do something different with that re start/stop lifecycle
There was a problem hiding this comment.
factory field in TransactionPoolValidatorServiceImpl is not volatile so the change could not be seen immediately by all thread, said that I prefer that the registration is done one, and the reload only updates the deny list, so for example restricting the moving pieces to a wrap of the deny list in a mutable container that is set at startup and updated on every reload, without having to redo all the initialization of the plugin
| @@ -124,6 +122,12 @@ public void start() { | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public CompletableFuture<Void> reloadConfiguration() { | |||
| loadDenyListAndRegisterPluginTxValidatorFactory(); | |||
There was a problem hiding this comment.
factory field in TransactionPoolValidatorServiceImpl is not volatile so the change could not be seen immediately by all thread, said that I prefer that the registration is done one, and the reload only updates the deny list, so for example restricting the moving pieces to a wrap of the deny list in a mutable container that is set at startup and updated on every reload, without having to redo all the initialization of the plugin
Signed-off-by: Sally MacFarlane <[email protected]>
allow config reload for LineaTransactionPoolValidatorPlugin.
Simplest possible implementation with no optimization.
Built on top of #99