-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prover: implements the top-level of the limitless prover #352
Draft
AlexandreBelling
wants to merge
16
commits into
main
Choose a base branch
from
prover/limitless-top-level
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
fb138fd
commit all ideas
AlexandreBelling 20db980
added aggregator
Soleimani193 4b4048f
adding details to top-level
Soleimani193 0043ba4
minor on lookup
Soleimani193 d6c26fe
removing preperation phase
Soleimani193 08b8b32
removed LogDerivativeSum
Soleimani193 c10afd4
minor
Soleimani193 73aef0e
minor typos
Soleimani193 fdb2526
distributed lookup compilation
Soleimani193 43b5e6e
Revert "distributed lookup compilation"
Soleimani193 1b04906
removing segParam
Soleimani193 0b4d797
implementation of extractDistModule()
Soleimani193 b426855
minor cleaning
Soleimani193 22ada9a
moving two functions from wizardutils to the column package
Soleimani193 a8ff658
Prover/Adding Initial Compiler for Permutation Query (#386)
arijitdutta67 54f9d33
initial framework for lookup (#428)
Soleimani193 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
package query | ||
|
||
import ( | ||
"github.com/consensys/gnark/frontend" | ||
"github.com/consensys/linea-monorepo/prover/protocol/ifaces" | ||
) | ||
|
||
type Projection struct { | ||
ID ifaces.QueryID | ||
ColumnsA, ColumnsB []ifaces.Column | ||
FilterA, FilterB ifaces.Column | ||
} | ||
|
||
// NewInclusion constructs an inclusion. Will panic if it is mal-formed | ||
func NewProjection( | ||
id ifaces.QueryID, | ||
columnsA, columnsB []ifaces.Column, | ||
filterA, filterB ifaces.Column, | ||
) Projection { | ||
|
||
return Projection{ColumnsA: columnsA, ColumnsB: columnsB, ID: id, FilterA: filterA, FilterB: filterB} | ||
} | ||
|
||
// Name implements the [ifaces.Query] interface | ||
func (r Projection) Name() ifaces.QueryID { | ||
return r.ID | ||
} | ||
|
||
// Check implements the [ifaces.Query] interface | ||
func (r Projection) Check(run ifaces.Runtime) error { | ||
|
||
panic("unimplemented") | ||
} | ||
|
||
// GnarkCheck implements the [ifaces.Query] interface. It will panic in this | ||
// construction because we do not have a good way to check the query within a | ||
// circuit | ||
func (i Projection) CheckGnark(api frontend.API, run ifaces.GnarkRuntime) { | ||
panic("UNSUPPORTED : can't check an Projection query directly into the circuit") | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you have a switch, it would be simpler to have one function for global, one for local and one for lookup, and one for projection and one for permutation. That way you don't have to do a switch in a switch, it's nicer to read that way.
You may want to move the
if disc.QueryIsInModule(v, moduleName)
our of the switch as it happens in all situations