Prover: implements the top-level of the limitless prover #352

AlexandreBelling · 2024-11-28T14:02:23Z

This PR implements issue(s) #

Checklist

I wrote new tests for my new core changes.
I have successfully ran tests, style checker and build against my new changes locally.
I have informed the team of any breaking changes if there are any.

codecov-commenter · 2024-11-28T14:07:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.18%. Comparing base (c356dc4) to head (54f9d33).
Report is 32 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main     #352   +/-   ##
=========================================
  Coverage     70.17%   70.18%           
  Complexity     1070     1070           
=========================================
  Files           306      306           
  Lines         12337    12338    +1     
  Branches       1179     1179           
=========================================
+ Hits           8658     8659    +1     
  Misses         3200     3200           
  Partials        479      479

Flag	Coverage Δ		*Carryforward flag
hardhat	`98.70% <ø> (+<0.01%)`	⬆️
kotlin	`67.86% <ø> (ø)`		Carriedforward from a8ff658

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

prover/protocol/distributed/distributed.go

arijitdutta67 · 2024-12-09T07:17:58Z

prover/protocol/distributed/distributed.go

+	// Analyze is responsible for letting the module discoverer compute how to
+	// group best the columns into modules.
+	Analyze(comp *wizard.CompiledIOP)
+	ModuleList(comp *wizard.CompiledIOP) []string


[]string -> []moduleName

arijitdutta67 · 2024-12-09T07:18:47Z

prover/protocol/distributed/distributed.go

+	Analyze(comp *wizard.CompiledIOP)
+	ModuleList(comp *wizard.CompiledIOP) []string
+	FindModule(col ifaces.Column) moduleName
+	FindNbSegments(moduleName string, SegParam map[string]int) int


A comment describing SegParam is helpful. Considering it gives the max segment size for a given module, consider map[string]int -> map[moduleName]int.

Why is that a member of the module discovery interface? And what are the parameters? From the code I understand that the function returns Segparams[moduleName], you don't need a function to do that

AlexandreBelling · 2024-12-09T17:32:53Z

prover/protocol/compiler/lookup/compiler.go

@@ -108,6 +114,10 @@ func CompileLogDerivative(comp *wizard.CompiledIOP) {
 		va.Name = zC.Name
 	}

+	if comp.HasSeed {


I don't understand what comp.HasSeed has to do with how the lookup compiler works. The only important thing is how the coin are sampled but then this logic should be implemented in the coin package.

AlexandreBelling · 2024-12-09T17:40:09Z

prover/protocol/compiler/lookup/prover.go

 		}
 	})
+	// assign the public input
+	run.AssignColumn(z.PI.GetColID(), sv.NewRegular([]field.Element{zSum}))


This should be in a dedicated logDerivative compiler object.

This reverts commit fdb2526.

AlexandreBelling · 2024-12-12T16:09:01Z

prover/protocol/distributed/distributed.go

+		// Filter LPP queries
+		q := comp.QueriesNoParams.Data(qName)
+
+		switch v := q.(type) {


Since you have a switch, it would be simpler to have one function for global, one for local and one for lookup, and one for projection and one for permutation. That way you don't have to do a switch in a switch, it's nicer to read that way.

You may want to move the if disc.QueryIsInModule(v, moduleName) our of the switch as it happens in all situations

* commit all ideas * added aggregator * initial framework added * added grand product query * Added initial framework of the grand prod query * module discoverer is added * added test for AddGdProduct * Prover action added * coin in grand product test, deriveName for GP added * Test with fragment added * added documentation --------- Signed-off-by: Arijit Dutta <[email protected]> Co-authored-by: AlexandreBelling <[email protected]> Co-authored-by: Soleimani193 <[email protected]>

* initial framework for lookup * added logderivative_sum query * added documentation * getting the multiplicity table from compild iop * added preparation for lookup * added IntoLogDerivationSum during the preparation * added the check for LogDerivativeSum query * added the test for LogDerivativeSum * moving two functions from wizardutils to the column package * adding module discoverer * added more methodes to module discoverer * test for distributing LogDerivSum passes without compiling the shares of LogDerivSum * test for distribution of the expressions passes --------- Co-authored-by: arijitdutta67 <[email protected]> Co-authored-by: AlexandreBelling <[email protected]>

AlexandreBelling added the Prover Tag to use for all work impacting the prover label Nov 28, 2024

AlexandreBelling requested review from arijitdutta67 and Soleimani193 November 28, 2024 14:02

AlexandreBelling self-assigned this Nov 28, 2024

AlexandreBelling had a problem deploying to docker-build-and-e2e November 28, 2024 14:03 — with GitHub Actions Error

Soleimani193 force-pushed the prover/limitless-top-level branch from 19846ef to 16fbcd9 Compare December 2, 2024 08:49

Soleimani193 had a problem deploying to docker-build-and-e2e December 2, 2024 08:49 — with GitHub Actions Error

AlexandreBelling commented Dec 2, 2024

View reviewed changes

prover/protocol/distributed/distributed.go Outdated Show resolved Hide resolved

AlexandreBelling commented Dec 2, 2024

View reviewed changes

prover/protocol/distributed/distributed.go Outdated Show resolved Hide resolved

AlexandreBelling commented Dec 2, 2024

View reviewed changes

prover/protocol/distributed/distributed.go Outdated Show resolved Hide resolved

Soleimani193 force-pushed the prover/limitless-top-level branch from 16fbcd9 to 2cae000 Compare December 6, 2024 09:28

Soleimani193 had a problem deploying to docker-build-and-e2e December 6, 2024 09:29 — with GitHub Actions Error

Soleimani193 had a problem deploying to docker-build-and-e2e December 6, 2024 09:47 — with GitHub Actions Error

Soleimani193 had a problem deploying to docker-build-and-e2e December 6, 2024 13:57 — with GitHub Actions Error

AlexandreBelling and others added 6 commits December 6, 2024 15:01

commit all ideas

fb138fd

added aggregator

20db980

adding details to top-level

4b4048f

minor on lookup

0043ba4

removing preperation phase

d6c26fe

removed LogDerivativeSum

08b8b32

Soleimani193 had a problem deploying to docker-build-and-e2e December 6, 2024 14:01 — with GitHub Actions Error

Soleimani193 force-pushed the prover/limitless-top-level branch from 3cec11b to 08b8b32 Compare December 6, 2024 14:01

Soleimani193 had a problem deploying to docker-build-and-e2e December 6, 2024 14:03 — with GitHub Actions Error

minor

c10afd4

Soleimani193 had a problem deploying to docker-build-and-e2e December 6, 2024 14:06 — with GitHub Actions Error

minor typos

73aef0e

Soleimani193 had a problem deploying to docker-build-and-e2e December 6, 2024 14:16 — with GitHub Actions Error

arijitdutta67 reviewed Dec 9, 2024

View reviewed changes

distributed lookup compilation

fdb2526

Soleimani193 had a problem deploying to docker-build-and-e2e December 9, 2024 14:19 — with GitHub Actions Error

AlexandreBelling commented Dec 9, 2024

View reviewed changes

Revert "distributed lookup compilation"

43b5e6e

This reverts commit fdb2526.

Soleimani193 had a problem deploying to docker-build-and-e2e December 10, 2024 09:05 — with GitHub Actions Error

removing segParam

1b04906

Soleimani193 had a problem deploying to docker-build-and-e2e December 11, 2024 08:16 — with GitHub Actions Error

implementation of extractDistModule()

0b4d797

Soleimani193 had a problem deploying to docker-build-and-e2e December 12, 2024 14:29 — with GitHub Actions Error

AlexandreBelling commented Dec 12, 2024

View reviewed changes

minor cleaning

b426855

Soleimani193 had a problem deploying to docker-build-and-e2e December 13, 2024 08:26 — with GitHub Actions Error

moving two functions from wizardutils to the column package

22ada9a

Soleimani193 had a problem deploying to docker-build-and-e2e December 19, 2024 08:53 — with GitHub Actions Error

AlexandreBelling had a problem deploying to docker-build-and-e2e December 20, 2024 12:56 — with GitHub Actions Error

AlexandreBelling requested a deployment to docker-build-and-e2e December 20, 2024 13:04 — with GitHub Actions Waiting

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prover: implements the top-level of the limitless prover #352

Prover: implements the top-level of the limitless prover #352

AlexandreBelling commented Nov 28, 2024

codecov-commenter commented Nov 28, 2024 •

edited

Loading

arijitdutta67 Dec 9, 2024

arijitdutta67 Dec 9, 2024 •

edited

Loading

AlexandreBelling Dec 9, 2024

AlexandreBelling Dec 9, 2024

AlexandreBelling Dec 9, 2024

AlexandreBelling Dec 12, 2024

Prover: implements the top-level of the limitless prover #352

Are you sure you want to change the base?

Prover: implements the top-level of the limitless prover #352

Conversation

AlexandreBelling commented Nov 28, 2024

Checklist

codecov-commenter commented Nov 28, 2024 • edited Loading

Codecov Report

arijitdutta67 Dec 9, 2024

Choose a reason for hiding this comment

arijitdutta67 Dec 9, 2024 • edited Loading

Choose a reason for hiding this comment

AlexandreBelling Dec 9, 2024

Choose a reason for hiding this comment

AlexandreBelling Dec 9, 2024

Choose a reason for hiding this comment

AlexandreBelling Dec 9, 2024

Choose a reason for hiding this comment

AlexandreBelling Dec 12, 2024

Choose a reason for hiding this comment

codecov-commenter commented Nov 28, 2024 •

edited

Loading

arijitdutta67 Dec 9, 2024 •

edited

Loading