Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More accurate calculation of areafact in remapping #849

Merged
merged 19 commits into from
Sep 15, 2023
Merged

More accurate calculation of areafact in remapping #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
87a3788
Modified doc to specify that l_fixed_area is T for C-grid
JFLemieux73 Jul 25, 2023
c66baf4
Initial modifs to calc areafact based on linear interpolation of left…
JFLemieux73 Jul 25, 2023
33317f3
put back l_fixed_area = .true. for C-grid
JFLemieux73 Jul 25, 2023
9df6bc7
added temporary comments for PR review
JFLemieux73 Jul 26, 2023
c4b573f
Modified areafac calc for case 1 and case 2
JFLemieux73 Aug 9, 2023
dd6e12a
Corrected minor compilation issues
JFLemieux73 Aug 9, 2023
978fdf3
Corrected conditions for case 1 to make sure areas add up
JFLemieux73 Aug 10, 2023
8fe3095
Small modif in l_fixed_area section to ensure only one condition is true
JFLemieux73 Aug 10, 2023
0ef0ac0
Modified conditions in locate triangle to be consistent with previous…
JFLemieux73 Aug 10, 2023
69a6374
Use other edge areafac_c for TL, BL, TR and BR triangles
JFLemieux73 Aug 23, 2023
7c287c3
Some comments removed
JFLemieux73 Aug 23, 2023
f3770d3
Fixed out of bounds areafac_ce and now use earea and narea
JFLemieux73 Aug 29, 2023
ad89a2a
Replaced ib,ie,jb,je in locate_triangle using ilo,ihi,jlo,jhi
JFLemieux73 Aug 29, 2023
0b9334b
Modified areafac for TL1, BL2, TR1 and BR2 for area flux consistency
JFLemieux73 Sep 8, 2023
ec88a55
Cosmetic changes
JFLemieux73 Sep 8, 2023
c56ca3e
Added comment to explain latest change
JFLemieux73 Sep 11, 2023
a571e82
Modification of bugcheck condition for l_fixed_area=T
JFLemieux73 Sep 12, 2023
261e9b6
update areafac_c, areafac_ce in halo in dynamics
apcraig Sep 14, 2023
1a4fd67
Merge pull request #1 from apcraig/far3
JFLemieux73 Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading