Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More accurate calculation of areafact in remapping #849

Merged
merged 19 commits into from
Sep 15, 2023
Merged

More accurate calculation of areafact in remapping #849

merged 19 commits into from
Sep 15, 2023

Commits on Sep 11, 2023

  1. Modified doc to specify that l_fixed_area is T for C-grid

    @JFLemieux73
    JFLemieux73 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    87a3788 View commit details
    Browse the repository at this point in the history

  2. Initial modifs to calc areafact based on linear interpolation of left… 

    … and rigth values
    @JFLemieux73
    JFLemieux73 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c66baf4 View commit details
    Browse the repository at this point in the history

  3. put back l_fixed_area = .true. for C-grid

    @JFLemieux73
    JFLemieux73 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    33317f3 View commit details
    Browse the repository at this point in the history

  4. added temporary comments for PR review

    @JFLemieux73
    JFLemieux73 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    9df6bc7 View commit details
    Browse the repository at this point in the history

  5. Modified areafac calc for case 1 and case 2

    @JFLemieux73
    JFLemieux73 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c4b573f View commit details
    Browse the repository at this point in the history

  6. Corrected minor compilation issues

    @JFLemieux73
    JFLemieux73 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    dd6e12a View commit details
    Browse the repository at this point in the history

  7. Corrected conditions for case 1 to make sure areas add up

    @JFLemieux73
    JFLemieux73 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    978fdf3 View commit details
    Browse the repository at this point in the history

  8. Small modif in l_fixed_area section to ensure only one condition is true

    @JFLemieux73
    JFLemieux73 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    8fe3095 View commit details
    Browse the repository at this point in the history

  9. Modified conditions in locate triangle to be consistent with previous… 

    … changes for case 1
    @JFLemieux73
    JFLemieux73 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    0ef0ac0 View commit details
    Browse the repository at this point in the history

  10. Use other edge areafac_c for TL, BL, TR and BR triangles

    @JFLemieux73
    JFLemieux73 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    69a6374 View commit details
    Browse the repository at this point in the history

  11. Some comments removed

    @JFLemieux73
    JFLemieux73 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    7c287c3 View commit details
    Browse the repository at this point in the history

  12. Fixed out of bounds areafac_ce and now use earea and narea

    @JFLemieux73
    JFLemieux73 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    f3770d3 View commit details
    Browse the repository at this point in the history

  13. Replaced ib,ie,jb,je in locate_triangle using ilo,ihi,jlo,jhi

    @JFLemieux73
    JFLemieux73 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    ad89a2a View commit details
    Browse the repository at this point in the history

  14. Modified areafac for TL1, BL2, TR1 and BR2 for area flux consistency

    @JFLemieux73
    JFLemieux73 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    0b9334b View commit details
    Browse the repository at this point in the history

  15. Cosmetic changes

    @JFLemieux73
    JFLemieux73 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    ec88a55 View commit details
    Browse the repository at this point in the history

  16. Added comment to explain latest change

    @JFLemieux73
    JFLemieux73 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c56ca3e View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Modification of bugcheck condition for l_fixed_area=T

    @JFLemieux73
    JFLemieux73 committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    a571e82 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. update areafac_c, areafac_ce in halo in dynamics

    @apcraig
    apcraig committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    261e9b6 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from apcraig/far3 

    Update areafac_c, areafac_ce in halo in dynamics
    @JFLemieux73
    JFLemieux73 committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    1a4fd67 View commit details
    Browse the repository at this point in the history