-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update emissivity to 0.985 and set nblyr default to 1 #553
Conversation
Do we need/want to do a QC test? Would we expect it to pass? |
A QC test would certainly be interesting. I wouldn't expect it to pass in stand-alone mode based on prior sensitivity tests, but it might pass. For completeness, I think it's a good idea to run a QC test. |
Change emissivity default to 0.985 (from 0.95) Change nblyr default to 1 (from 7) Add nblyr=7 to set_nml.zsal Update Icepack to include emissivity default changes Update documentation as needed
The QC test passed on cheyenne. I'm not sure whether this is a good or bad outcome. INFO:main:Running QC test on the following directories: |
Was this run with JRA forcing? Then it's good. I'd expect it to fail with the old forcing, which is a lot of the reason for moving to JRA. Sensitivities using the old forcing had the wrong sign! |
Yes, this is with JRA55 forcing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to merge this, assuming that the issues that @dabail10 is turning up are related to configuration settings specific to his tests rather than these code changes.
This was a problem related to my setup and not the emissivity value change. |
I just verified that even with emissivity of 0.95, I cannot do a run crossing 1996 to 1997 (starting in 1995) with my JRA forcing. I believe there is a leap year related issue here. I will open a separate issue. |
PR checklist
Update emissivity to 0.985 and set nblyr default to 1
apcraig
Full test suites run on cheyenne on 3 compilers, most results are NOT bit-for-bit.
https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#c4b9051c28db9ab818669133a72be687d8846c0e
See #249
Change emissivity default to 0.985 (from 0.95)
Change nblyr default to 1 (from 7)
Add nblyr=7 to set_nml.zsal
Update Icepack to include emissivity default changes
Update documentation as needed