Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions test-cice.yml script #555

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Jan 20, 2021

PR checklist

  • Short (1 sentence) summary of your PR:
    Add Github Actions scripts
  • Developer(s):
    apcraig, phil-blain
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    No testing done except in github actions, https://github.com/apcraig/CICE/runs/1738212948
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Similar to recent Icepack changes, alternative to travis-ci.

See #550

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like travis-CI will still be an option. Is it now off by default? I'm not sure how this all works, but happy to go with these changes. Thanks for figuring it out.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Philippe Blain <[email protected]>
@apcraig
Copy link
Contributor Author

apcraig commented Jan 21, 2021

@eclare108213, we are still waiting on the situation with Travis-CI. We can't use it right now because we don't have an allocation. In the past, all open source project got unlimited resources. That's no longer the case. I have requested that we be granted an allocation on Travis-CI but have not heard anything back. For now, I'm just leaving it "on", but it's not running. In the future, we may or may not have Travis-CI, but we will have Github Actions as an alternative and we could use either or both if Travis-CI is available again.

@phil-blain
Copy link
Member

An added benefit is that the GitHub Actions workflow use the conda environment, so we continuously test the conda setup. If for some reason the created conda environment has problems (like the recent OpenMP bug in the GFortran compiler from conda-forge), then we will immediately notice.

@apcraig
Copy link
Contributor Author

apcraig commented Jan 21, 2021

@phil-blain, that's also true and a very handy feature and in part why I'd like to get the linux (ubuntu) working as well.

I wonder why GH Actions is not being triggered on this PR. For the Icepack PR, it didn't initially either, but then it did at some point. Some things are quite the mystery. Hopefully, GH Actions will trigger automatically once we get this PR merged. I would have more confidence if it would be happening now. I'll merge, and we'll go from there.

@apcraig apcraig merged commit 078c49a into CICE-Consortium:master Jan 21, 2021
@apcraig
Copy link
Contributor Author

apcraig commented Jan 21, 2021

GH Actions seems to be triggered as we hoped. See #553

@apcraig apcraig deleted the ghactionsB branch August 17, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants