Added: QTE Framework #1649

john681611 · 2024-03-19T23:42:34Z

When merged this pull request will:

Provide Quick Time Events for players to enter in order to complete action (capability addition not change any existing functionality)
Respect the Submitting Content Guidelines
Migrated from Add Quick Time Events acemod/ACE3#9849

addons/common/fnc_generateQTESequence.sqf

johnb432 · 2024-03-20T11:12:37Z

addons/common/fnc_runQTE.sqf

+if (!GVAR(settingsInitFinished)) exitWith {
+	// only run this after the settings are initialized
+	GVAR(runAtSettingsInitialized) pushBack [FUNC(runQTE), _this];
+};


For now leave this aside, or bring it up-to-date with CBA.

johnb432 · 2024-03-20T11:17:13Z

addons/common/fnc_runQTE.sqf

+	TRACE_1("QTE already running qeueing up", GVAR(QTERunning));
+	[{
+		!GVAR(QTERunning)
+	}, {
+		_this call FUNC(runQTE);
+	}, _this] call CBA_fnc_waitUntilAndExecute;
+};
+
+private _display = findDisplay 46;
+
+if (isNull _display) exitWith {
+	TRACE_1("Waiting for main display to be ready", isNull (_display));
+	[{
+		!isNull (findDisplay 46)
+	}, {
+		_this call FUNC(runQTE);
+	}, _this] call CBA_fnc_waitUntilAndExecute;


Imo it should be up to the user to check whenever it's ready. This should only return false or an error code that it couldn't run. The removal of these waitUntilAndExecute would make the _onDisplay event redundant.

~~The display on which the QTE is drawn should be an argument, so that people can run it wherever they want to (e.g. Zeus interface).~~ Because of comment below, this is no longer relevant.

johnb432 · 2024-03-20T11:45:48Z

addons/common/fnc_runQTE.sqf

+	private _inputKeys = [DIK_UP, DIK_DOWN, DIK_LEFT, DIK_RIGHT];
+	switch (GVAR(QTEInputKeys)) do {
+		case 1: {
+			_inputKeys = [DIK_W, DIK_S, DIK_A, DIK_D];
+		};
+		case 2: {
+			_inputKeys = [DIK_I, DIK_K, DIK_J, DIK_L];
+		};
+		case 3: {
+			_inputKeys = [DIK_NUMPAD8, DIK_NUMPAD2, DIK_NUMPAD4, DIK_NUMPAD6];
+		};
+		default {
+			_inputKeys = [DIK_UP, DIK_DOWN, DIK_LEFT, DIK_RIGHT];
+		};
+	};


I really dislike this strongly. It uses CBA settings for keybind sets, when we can use CBA keybinds instead.
This would allow for way more flexibility and customisability, as 3rd party mods or mod makers could add their own extra keybinds.

Register 4 keybinds. Here's an example (strings would need to be localised and improved):

["QTE Keybinds", QGVAR(keyUpQTE), ["QTE up key", "Up key used in QTE events."], { ["↑"] call FUNC(keyPressedQTE); // return }, {}, [DIK_UP, [false, false, false]]] call CBA_fnc_addKeybind;

In fnc_keyPressedQTE, you'd check if the keypress is good or not:

params ["_eventQTE"]; // Check if the passed parameter is the next key in the QTE sequence // If yes, continue // If no, stop

Imo, we should make the QTE agonistic of the QTE chars themselves ("↑"). That should be configurable by the user. It will add an extra layer of complexity to the whole things, so we'll have to see if it's worth it.

Let's keep it simple and start with assigning keys to "↑" etc then we can look at expanding to other keys.

Co-authored-by: johnb432 <[email protected]>

…uickTimeEvents

john681611 · 2024-03-23T20:07:39Z

@johnb432 ~~Only thing I've not managed to get working is the keybinds actually calling the function~~
Ok defaulting my keybinds worked

rautamiekka · 2024-03-23T21:22:53Z

addons/common/XEH_preInit.sqf

@@ -78,3 +79,19 @@ activateAddons GVAR(addons);
 ["CAManBase", "InitPost", CBA_fnc_randomizeFacewear] call CBA_fnc_addClassEventHandler;

 ADDON = true;
+
+["CBA QTE", "QTE_Up_Key", ["↑", "Up key used in QTE events."], {}, {


Personally have a problem with QTE events cuz it expands into Quick-Time Event events.

Making it Quick-Time Events ain't just 2 letters longer, I admit, but shouldn't matter:

Up key used in QTE events. Up key used in Quick-Time Events.

rautamiekka · 2024-03-23T21:23:58Z

addons/common/fnc_getFormattedQTESequence.sqf

+ * [["↑", "↓", "→", "←"]] call ace_common_fnc_getFormattedQTESequence
+ *
+ * Public: Yes
+ */


The other headers are formatted different from this one.

rautamiekka · 2024-03-23T21:24:52Z

addons/common/fnc_keyPressedQTE.sqf

+};
+
+if (_onDisplay isEqualType "") then {
+	[_onDisplay, 	[_args, _qte_seqence,  GVAR(QTEHistory)]] call CBA_fnc_localEvent;


Suggested change

[_onDisplay, [_args, _qte_seqence, GVAR(QTEHistory)]] call CBA_fnc_localEvent;

[_onDisplay, [_args, _qte_sequence, GVAR(QTEHistory)]] call CBA_fnc_localEvent;

rautamiekka · 2024-03-23T21:25:07Z

addons/common/fnc_keyPressedQTE.sqf

+if (_onDisplay isEqualType "") then {
+	[_onDisplay, 	[_args, _qte_seqence,  GVAR(QTEHistory)]] call CBA_fnc_localEvent;
+} else {
+	[_args, _qte_seqence,  GVAR(QTEHistory)] call _onDisplay;


Suggested change

[_args, _qte_seqence, GVAR(QTEHistory)] call _onDisplay;

[_args, _qte_sequence, GVAR(QTEHistory)] call _onDisplay;

rautamiekka · 2024-03-23T21:25:44Z

addons/common/fnc_runQTE.sqf

+ 	_onDisplay - Code callback on displayable event passed [_args, _qte_seqence, _qte_history]. <CODE, STRING>
+	_onFinish - Code callback on QTE completed passed [_args, _elapsedTime]. <CODE, STRING>
+	_onFinish - Code callback on QTE timeout/outranged passed [_args, _elapsedTime]. <CODE, STRING>
+ 	_qte_seqence - QTE seqence usually made up of ["↑", "↓", "→", "←"] <ARRAY>


Suggested change

_qte_seqence - QTE seqence usually made up of ["↑", "↓", "→", "←"] <ARRAY>

_qte_seqence - QTE sequence usually made up of ["↑", "↓", "→", "←"] <ARRAY>

rautamiekka · 2024-03-23T21:26:31Z

addons/common/fnc_runQTE.sqf

+
+Example:
+    [
+		car,


A lot of tabs in this file at least.

rautamiekka · 2024-03-23T21:27:54Z

addons/common/fnc_generateQTESequence.sqf

+    [5] call CBA_fnc_generateQTESequence;
+
+Returns:
+    QTE seqence of requested length made up of ["↑", "↓", "→", "←"] <ARRAY>


Suggested change

QTE seqence of requested length made up of ["↑", "↓", "→", "←"] <ARRAY>

QTE sequence of requested length made up of ["↑", "↓", "→", "←"] <ARRAY>

rautamiekka · 2024-03-23T21:28:09Z

addons/common/fnc_keyPressedQTE.sqf

+private _onFinish = GVAR(QTEArgs) get "onFinish";
+private _onFail = GVAR(QTEArgs) get "onFail";
+private _max_distance = GVAR(QTEArgs) get "max_distance";
+private _qte_seqence = GVAR(QTEArgs) get "qte_seqence";


Suggested change

private _qte_seqence = GVAR(QTEArgs) get "qte_seqence";

private _qte_sequence = GVAR(QTEArgs) get "qte_sequence";

rautamiekka · 2024-03-23T21:28:21Z

addons/common/fnc_keyPressedQTE.sqf

+GVAR(QTEHistory) pushBack _eventQTE;
+
+
+if (GVAR(QTEHistory) isEqualTo _qte_seqence) exitWith {


Suggested change

if (GVAR(QTEHistory) isEqualTo _qte_seqence) exitWith {

if (GVAR(QTEHistory) isEqualTo _qte_sequence) exitWith {

rautamiekka · 2024-03-23T21:28:39Z

addons/common/fnc_keyPressedQTE.sqf

+	};
+};
+
+if !(GVAR(QTEHistory) isEqualTo (_qte_seqence select [0, count GVAR(QTEHistory)])) then {


Suggested change

if !(GVAR(QTEHistory) isEqualTo (_qte_seqence select [0, count GVAR(QTEHistory)])) then {

if !(GVAR(QTEHistory) isEqualTo (_qte_sequence select [0, count GVAR(QTEHistory)])) then {

rautamiekka · 2024-03-23T21:28:52Z

addons/common/fnc_runQTE.sqf

+Parameters:
+	_object - <OBJECT>
+	_args - Extra arguments passed to the _on... functions<ARRAY>
+ 	_onDisplay - Code callback on displayable event passed [_args, _qte_seqence, _qte_history]. <CODE, STRING>


Suggested change

_onDisplay - Code callback on displayable event passed [_args, _qte_seqence, _qte_history]. <CODE, STRING>

_onDisplay - Code callback on displayable event passed [_args, _qte_sequence, _qte_history]. <CODE, STRING>

johnb432

I haven't reviewed the functionality yet, this is mostly formatting related.

addons/common/XEH_preInit.sqf

addons/common/fnc_generateQTESequence.sqf

addons/common/fnc_keyPressedQTE.sqf

johnb432 · 2024-03-25T15:49:34Z

addons/common/fnc_keyPressedQTE.sqf

+	Process Quick-Time Key Press
+
+Parameters:
+    _eventQTE - <STRING>


Argument needs description.

johnb432 · 2024-03-25T15:51:36Z

addons/common/fnc_keyPressedQTE.sqf

+    ["↑"] call CBA_fnc_keyPressedQTE;
+
+Returns:
+    Nil


It would be None, but the whole point of using a function over an event is so that you can return something.

We want to "override" input if it's a valid QTE keypress, meaning that e.g. if you have bound your arrow up key to move forwards, you wouldn't move forwards while you are doing a QTE.

Is this where we return true/false in terms of input override?

johnb432 · 2024-03-25T16:00:08Z

addons/common/fnc_runQTE.sqf

+	TRACE_1("QTE already running qeueing up",GVAR(QTERunning));
+	[{
+		!GVAR(QTERunning)
+	}, {
+		_this call FUNC(runQTE);
+	}, _this] call CBA_fnc_waitUntilAndExecute;


I'm still not a fan of this. Depending, we might have to wait indefinitely. It also means that multiple QTE can queue up, which could cause unforeseen headaches, albeit unlikely.

I think we'd be better off returning a boolean telling the caller if the QTE was successfully run or not.

johnb432 · 2024-03-25T16:00:49Z

addons/common/fnc_runQTE.sqf

+	["start_time", _start_time],
+	["timeout", _timeout]
+];
+GVAR(QTEArgs) = createHashMapObject [_qteArgsArray];


As far as I can tell, there is no reason to use a hashmap object.

Suggested change

GVAR(QTEArgs) = createHashMapObject [_qteArgsArray];

GVAR(QTEArgs) = createHashMapFromArray [_qteArgsArray];

addons/common/fnc_runQTE.sqf

addons/common/stringtable.xml

johnb432 · 2024-03-25T16:05:30Z

addons/common/fnc_runQTE.sqf

+	} else {
+		[_args, _elapsedTime] call _onFail;
+	};
+}, _this] call CBA_fnc_waitUntilAndExecute;


You can't pass _this when using default arguments. The default arguments are not inserted into _this, you'll have to pass each argument individually in an array.

Regardless, _this here does not make sense. Pass [_object, _start_time, _timeout, _max_distance] and read those in the loop instead - unless reading from GVAR(QTEArgs) is faster?

rautamiekka

Most files use tabs instead of spaces.
The fnc headers are different from the ones in use. For ex: 698aee1
Apart from a couple extra tabs/spaces I added a suggestion for, lgtm.

rautamiekka · 2024-03-25T17:11:34Z

addons/common/fnc_keyPressedQTE.sqf

+	[_onDisplay, 	[_args, _qte_sequence,  GVAR(QTEHistory)]] call CBA_fnc_localEvent;
+} else {
+	[_args, _qte_sequence,  GVAR(QTEHistory)] call _onDisplay;


Suggested change

[_onDisplay, [_args, _qte_sequence, GVAR(QTEHistory)]] call CBA_fnc_localEvent;

} else {

[_args, _qte_sequence, GVAR(QTEHistory)] call _onDisplay;

[_onDisplay, [_args, _qte_sequence, GVAR(QTEHistory)]] call CBA_fnc_localEvent;

} else {

[_args, _qte_sequence, GVAR(QTEHistory)] call _onDisplay;

Co-authored-by: johnb432 <[email protected]>

john681611 · 2024-03-26T07:14:16Z

Is there a linter in the repo I can run or format config just to save time on these formatting comments?

Co-authored-by: johnb432 <[email protected]>

Co-authored-by: Jouni Järvinen <[email protected]>

johnb432 · 2024-03-31T17:56:07Z

Is there a linter in the repo I can run or format config just to save time on these formatting comments?

No, I don't think so.

addons/common/fnc_runQTE.sqf

Co-authored-by: Jouni Järvinen <[email protected]>

addons/common/fnc_runQTE.sqf

Co-authored-by: Jouni Järvinen <[email protected]>

rautamiekka

As far as I can tell by eyesight everything's good, but don't just take my word for it.

john681611 · 2024-04-06T08:31:46Z

Thanks for the reviews guys sorry its 90% formatting issues.

johnb432 · 2024-04-30T20:18:32Z

addons/common/XEH_preInit.sqf

@@ -78,3 +79,19 @@ activateAddons GVAR(addons);
 ["CAManBase", "InitPost", CBA_fnc_randomizeFacewear] call CBA_fnc_addClassEventHandler;

 ADDON = true;


All the code should be added before this line.

However, more importantly adding keybinds in common doesn't work. keybinding depends on common, meaning the code below is called when CBA_fnc_addKeybind is not defined.

This means that this code needs to be moved to another component. I'm not sure if events is the right place or if we should add another component, just for this.

addons/common/XEH_preInit.sqf

…uickTimeEvents

Co-authored-by: johnb432 <[email protected]>

…uickTimeEvents

johnb432

It's looking pretty good, but some changes are needed.

johnb432 · 2024-05-04T14:29:29Z

addons/quicktime/XEH_preStart.sqf

Don't need this file, remove it.

johnb432 · 2024-05-04T14:29:47Z

addons/quicktime/CfgEventHandlers.hpp

+class Extended_PreStart_EventHandlers {
+    class ADDON {
+        init = QUOTE(call COMPILE_SCRIPT(XEH_preStart));
+    };
+};
+


Remove along with the file.

johnb432 · 2024-05-04T14:30:13Z

addons/quicktime/CfgFunctions.hpp

+            PATHTO_FNC(runQTE);
+            PATHTO_FNC(keyPressedQTE);


Order them alphabetically.

Suggested change

PATHTO_FNC(runQTE);

PATHTO_FNC(keyPressedQTE);

PATHTO_FNC(keyPressedQTE);

PATHTO_FNC(runQTE);

johnb432 · 2024-05-04T14:31:16Z

addons/quicktime/fnc_runQTE.sqf

+if (GVAR(QTERunning)) exitWith {
+    false
+};


GVAR(QTERunning) is undefined on the first time it's run.

Suggested change

if (GVAR(QTERunning)) exitWith {

false

};

if !(missionNamespace getVariable [QGVAR(QTERunning), false]) exitWith {

false

};

You could move this line above the params line, as this doesn't require any arguments.

johnb432 · 2024-05-04T14:31:54Z

addons/quicktime/fnc_runQTE.sqf

+    ["onFinish", _onFinish],
+    ["onFail", _onFail],
+    ["maxDistance", _maxDistance],
+    ["qteSeqence", _qteSequence],


Minor typo has slipped in (change where necessary).

Suggested change

["qteSeqence", _qteSequence],

["qteSequence", _qteSequence],

johnb432 · 2024-05-04T14:33:26Z

addons/quicktime/fnc_runQTE.sqf

+    private _onFail = (GVAR(QTEArgs) get "onFail");
+    private _args = (GVAR(QTEArgs) get "args");


Unnecessary parenthesis:

Suggested change

private _onFail = (GVAR(QTEArgs) get "onFail");

private _args = (GVAR(QTEArgs) get "args");

private _onFail = GVAR(QTEArgs) get "onFail";

private _args = GVAR(QTEArgs) get "args";

johnb432 · 2024-05-04T14:34:54Z

addons/quicktime/fnc_keyPressedQTE.sqf

+
+GVAR(QTEHistory) pushBack _eventQTE;
+
+


Suggested change

// Check if the input corresponds to the sequence

johnb432 · 2024-05-04T14:35:55Z

addons/quicktime/fnc_keyPressedQTE.sqf

+    };
+    true
+};
+


Suggested change

// If the user failed an input, wipe the previous input from memory

johnb432 · 2024-05-04T14:41:47Z

addons/quicktime/fnc_runQTE.sqf

+    private _maxDistance = GVAR(QTEArgs) get "maxDistance";
+    private _elapsedTime = CBA_missionTime - (GVAR(QTEArgs) get "startTime");
+
+    !GVAR(QTERunning) || player distance _object > _maxDistance || _elapsedTime > _timeout;


I think having player distance _object > _maxDistance as a condition is a very limiting factor. In some cases one might not want or need to have such a condition, but would rather use others.
The condition code should be passed by the user, it would be {false} by default (meaning the timeout would be the default method of ending the QTE if it isn't solved in time). object and maxDistance would no longer be needed.

You'd evaluate it by calling _args call _condition, with _args being the same args as the event/function one.
The function header would need to be adjusted accordingly.

Why not go a step further and remove the timeout and just pass [_args, _elapsedTime]. This would allow for unlimited time variants too. Its also standard for all functions then.

johnb432 · 2024-05-04T14:49:08Z

addons/quicktime/fnc_runQTE.sqf

+---------------------------------------------------------------------------- */
+
+
+params ["_object", "_args", "_onDisplay", "_onFinish", "_onFail", "_qteSequence", ["_maxDistance", 10], ["_timeout", 30]];


Since this is a public function, we need to sanitise the input:

Suggested change

params ["_object", "_args", "_onDisplay", "_onFinish", "_onFail", "_qteSequence", ["_maxDistance", 10], ["_timeout", 30]];

params [["_object", objNull, [objNull]], "_args", ["_onDisplay", {}, ["", {}]], ["_onFinish", {}, ["", {}]], ["_onFail", {}, ["", {}]], ["_qteSequence", [], [[]]], ["_maxDistance", 10, [0]], ["_timeout", 30, [0]]];

You need to check if the input are valid (e.g. an empty QTE sequence should not be allowed).

I haven't taken into account the other proposals I've made, so you'll need to adapt accordingly.

john681611 · 2024-05-05T16:39:09Z

Decided to go down the maximum flexibility route. We will let users define their conditions of failure entirely. I'm also passing a reset count so attempts can be implemented.

johnb432 · 2024-05-09T21:21:47Z

Quick glance over changes: Looks good, but I'll take a more detailed look later.

john681611 · 2024-06-04T12:52:59Z

Is there any progress on this?

addons/quicktime/fnc_runQTE.sqf

Mike-MF · 2024-06-23T18:11:41Z

Aside from the typo I saw, I played around with this. It's really nice, I like the configuration aspects to it too. I did a bunch of things with it and couldn't find a way to break it.

Nice job.

Co-authored-by: Mike-MF <[email protected]>

johnb432

LGTM

Added: QTE Framework

ea657b5

john681611 marked this pull request as draft March 19, 2024 23:42

johnb432 reviewed Mar 20, 2024

View reviewed changes

john681611 and others added 4 commits March 21, 2024 18:16

Update addons/common/fnc_generateQTESequence.sqf

964cefe

Co-authored-by: johnb432 <[email protected]>

refactor to use Keybinds

45929cd

Merge branch 'quickTimeEvents' of github.com:john681611/CBA_A3 into q…

bfa6ea8

…uickTimeEvents

Fix null issue on key press

3576e8e

john681611 marked this pull request as ready for review March 23, 2024 20:11

rautamiekka reviewed Mar 23, 2024

View reviewed changes

rautamiekka suggested changes Mar 23, 2024

View reviewed changes

john681611 added 2 commits March 23, 2024 22:17

review improvements

dbc5abe

Support localization

d35bfb8

john681611 requested review from johnb432 and rautamiekka March 25, 2024 12:02

johnb432 reviewed Mar 25, 2024

View reviewed changes

rautamiekka suggested changes Mar 25, 2024

View reviewed changes

john681611 and others added 5 commits March 26, 2024 07:10

Update addons/common/XEH_preInit.sqf

986d828

Co-authored-by: johnb432 <[email protected]>

Update addons/common/fnc_generateQTESequence.sqf

26529cc

Co-authored-by: johnb432 <[email protected]>

Update addons/common/fnc_keyPressedQTE.sqf

5255969

Co-authored-by: johnb432 <[email protected]>

Update addons/common/fnc_runQTE.sqf

96806a9

Co-authored-by: johnb432 <[email protected]>

Update addons/common/stringtable.xml

6597fc8

Co-authored-by: johnb432 <[email protected]>

john681611 and others added 5 commits March 26, 2024 07:30

Update addons/common/fnc_keyPressedQTE.sqf

9feffc8

Co-authored-by: johnb432 <[email protected]>

Update addons/common/fnc_keyPressedQTE.sqf

c851040

Co-authored-by: johnb432 <[email protected]>

Update addons/common/fnc_keyPressedQTE.sqf

68c586b

Co-authored-by: johnb432 <[email protected]>

review comments

f48ebaa

minor improvements

d99bb4f

john681611 requested review from johnb432 and rautamiekka March 27, 2024 09:49

Update addons/common/fnc_runQTE.sqf

29f9f11

Co-authored-by: Jouni Järvinen <[email protected]>

john681611 requested a review from rautamiekka April 2, 2024 13:42

rautamiekka suggested changes Apr 2, 2024

View reviewed changes

addons/common/fnc_runQTE.sqf Outdated Show resolved Hide resolved

addons/common/fnc_runQTE.sqf Outdated Show resolved Hide resolved

john681611 and others added 2 commits April 2, 2024 18:24

Update addons/common/fnc_runQTE.sqf

1fbb063

Co-authored-by: Jouni Järvinen <[email protected]>

Update addons/common/fnc_runQTE.sqf

c8e951b

Co-authored-by: Jouni Järvinen <[email protected]>

rautamiekka suggested changes Apr 2, 2024

View reviewed changes

addons/common/fnc_runQTE.sqf Outdated Show resolved Hide resolved

Update addons/common/fnc_runQTE.sqf

24bf821

Co-authored-by: Jouni Järvinen <[email protected]>

rautamiekka approved these changes Apr 2, 2024

View reviewed changes

johnb432 suggested changes Apr 30, 2024

View reviewed changes

john681611 and others added 7 commits April 30, 2024 21:29

format: camelcasing

9eb7b18

Merge branch 'quickTimeEvents' of github.com:john681611/CBA_A3 into q…

7dc983f

…uickTimeEvents

Update addons/common/XEH_preInit.sqf

a22d373

Co-authored-by: johnb432 <[email protected]>

migrate to quicktime component

9a6cfb2

Merge branch 'quickTimeEvents' of github.com:john681611/CBA_A3 into q…

976eca3

…uickTimeEvents

minor fixes

6d2f3fe

Fix sneaky keybind error

6024704

johnb432 suggested changes May 4, 2024

View reviewed changes

john681611 added 2 commits May 5, 2024 16:15

Review comment improvements

8e236f2

Use more generic condition and reset counter

83ca39f

veteran29 self-requested a review June 4, 2024 17:59

veteran29 added the Feature label Jun 4, 2024

Mike-MF reviewed Jun 23, 2024

View reviewed changes

addons/quicktime/fnc_runQTE.sqf Outdated Show resolved Hide resolved

Update addons/quicktime/fnc_runQTE.sqf

46d200d

Co-authored-by: Mike-MF <[email protected]>

johnb432 approved these changes Jun 28, 2024

View reviewed changes

	[_onDisplay, [_args, _qte_seqence, GVAR(QTEHistory)]] call CBA_fnc_localEvent;
	[_onDisplay, [_args, _qte_sequence, GVAR(QTEHistory)]] call CBA_fnc_localEvent;

	[_args, _qte_seqence, GVAR(QTEHistory)] call _onDisplay;
	[_args, _qte_sequence, GVAR(QTEHistory)] call _onDisplay;

	_qte_seqence - QTE seqence usually made up of ["↑", "↓", "→", "←"] <ARRAY>
	_qte_seqence - QTE sequence usually made up of ["↑", "↓", "→", "←"] <ARRAY>

	QTE seqence of requested length made up of ["↑", "↓", "→", "←"] <ARRAY>
	QTE sequence of requested length made up of ["↑", "↓", "→", "←"] <ARRAY>

	private _qte_seqence = GVAR(QTEArgs) get "qte_seqence";
	private _qte_sequence = GVAR(QTEArgs) get "qte_sequence";

		GVAR(QTEHistory) pushBack _eventQTE;


		if (GVAR(QTEHistory) isEqualTo _qte_seqence) exitWith {

	if (GVAR(QTEHistory) isEqualTo _qte_seqence) exitWith {
	if (GVAR(QTEHistory) isEqualTo _qte_sequence) exitWith {

	if !(GVAR(QTEHistory) isEqualTo (_qte_seqence select [0, count GVAR(QTEHistory)])) then {
	if !(GVAR(QTEHistory) isEqualTo (_qte_sequence select [0, count GVAR(QTEHistory)])) then {

	_onDisplay - Code callback on displayable event passed [_args, _qte_seqence, _qte_history]. <CODE, STRING>
	_onDisplay - Code callback on displayable event passed [_args, _qte_sequence, _qte_history]. <CODE, STRING>

	GVAR(QTEArgs) = createHashMapObject [_qteArgsArray];
	GVAR(QTEArgs) = createHashMapFromArray [_qteArgsArray];

		@@ -78,3 +79,19 @@ activateAddons GVAR(addons);
		["CAManBase", "InitPost", CBA_fnc_randomizeFacewear] call CBA_fnc_addClassEventHandler;

		ADDON = true;

		private _onFail = (GVAR(QTEArgs) get "onFail");
		private _args = (GVAR(QTEArgs) get "args");



	// If the user failed an input, wipe the previous input from memory

		---------------------------------------------------------------------------- */


		params ["_object", "_args", "_onDisplay", "_onFinish", "_onFail", "_qteSequence", ["_maxDistance", 10], ["_timeout", 30]];

	params ["_object", "_args", "_onDisplay", "_onFinish", "_onFail", "_qteSequence", ["_maxDistance", 10], ["_timeout", 30]];
	params [["_object", objNull, [objNull]], "_args", ["_onDisplay", {}, ["", {}]], ["_onFinish", {}, ["", {}]], ["_onFail", {}, ["", {}]], ["_qteSequence", [], [[]]], ["_maxDistance", 10, [0]], ["_timeout", 30, [0]]];

Added: QTE Framework #1649

Are you sure you want to change the base?

Added: QTE Framework #1649

Conversation

john681611 commented Mar 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

john681611 Mar 21, 2024 • edited Loading

Choose a reason for hiding this comment

john681611 commented Mar 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johnb432 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rautamiekka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

john681611 commented Mar 26, 2024

johnb432 commented Mar 31, 2024

rautamiekka left a comment

Choose a reason for hiding this comment

john681611 commented Apr 6, 2024

johnb432 Apr 30, 2024 • edited Loading

Choose a reason for hiding this comment

johnb432 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

john681611 commented May 5, 2024

johnb432 commented May 9, 2024

john681611 commented Jun 4, 2024

Mike-MF commented Jun 23, 2024

johnb432 left a comment

Choose a reason for hiding this comment

john681611 Mar 21, 2024 •

edited

Loading

john681611 commented Mar 23, 2024 •

edited

Loading

johnb432 Apr 30, 2024 •

edited

Loading