improvements to the diff panel #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanherk
approved these changes
Jul 12, 2023
svanherk
reviewed
Jul 12, 2023
| .result-part-info-spacer, | ||
| .result-part-info-size { | ||
| flex: 1 0 0%; | ||
| text-align: right; |
There was a problem hiding this comment.
I think I like this slightly better text-align: left; (and gap reduced) but I see the benefit of having both at the ends
|
Oh, also just noticed the passed tests are looking a little squished lol: |
|
Oooh that is squishy and ugly! Yeah maybe it makes sense to flip those around... I'll fix this stuff up thanks! |
|
🎉 This PR is included in version 0.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some mostly minor improvements to the area where the actual diff is shown:
I decided that having a separate web component for the test result wasn't working out, so I've merged it into the test one. As a follow-up, I think I'm going to merge the test one into the app as well and split styles and render helpers out into separate files. Ultimately here there was no advantage to having separate components if they're only used from one place -- lesson learned.