Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix case where golden and new match #70

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

dlockhart
Copy link
Member

Some follow-up fixes to #68 based on feedback from Stacey.

Sizes are now left aligned but the names are still centred:
Screenshot 2023-07-12 at 5 12 43 PM

Fixes the case where the goldens match the new and it was super squished and ugly. Also flipped it around so the "no changes" message shows on the right side.
Screenshot 2023-07-12 at 5 11 12 PM

@dlockhart dlockhart requested a review from a team as a code owner July 12, 2023 21:13
Copy link
Contributor

@svanherk svanherk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha love it! Now I want a collection of happy images that are randomly selected 😝

@dlockhart dlockhart merged commit 72d9f8d into main Jul 12, 2023
1 check passed
@dlockhart dlockhart deleted the dlockhart/diff-panel-fixes branch July 12, 2023 22:19
@ghost
Copy link

ghost commented Jul 17, 2023

🎉 This PR is included in version 0.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants