feat: install playwright dependencies ourselves #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
commented
Aug 10, 2023
| @@ -196,7 +197,12 @@ async function getTestRunnerOptions(argv = []) { | |||
| }; | |||
| } | |||
|
|
|||
| function installDeps() { | |||
| execSync('npx playwright install-deps', { stdio: 'pipe' }); | |||
There was a problem hiding this comment.
I played around with the async version of this and wrapped it in a Promise, but marshalling the stdout/err around seemed way more complicated than it was worth. Open to other suggestions though.
bearfriend
reviewed
Aug 10, 2023
bearfriend
approved these changes
Aug 10, 2023
Co-authored-by: Danny Gleckler <[email protected]>
|
🎉 This PR is included in version 0.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid consumers having to run this in CI anytime they use
d2l-test-runner, this installs it automatically for them. In testing, it appears to be a no-op if they're already installed.