switch to @brightspace-ui/testing #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
commented
Aug 10, 2023
.github/workflows/visual-diff.yml
Outdated
There was a problem hiding this comment.
This doesn't do anything since there are no tests, so removing it temporarily.
| Replace `X`, `Y` and `Z` with [the current versions](https://github.com/BrightspaceUI/actions/tree/main/visual-diff#current-dependency-versions) the action is using. | ||
|
|
||
| Then run the tests: | ||
| This repo uses [@brightspace-ui/testing](https://github.com/BrightspaceUI/testing)'s vdiff command to perform visual regression testing: |
There was a problem hiding this comment.
Technically this isn't true (yet).
bearfriend
reviewed
Aug 10, 2023
bearfriend
approved these changes
Aug 10, 2023
Co-authored-by: Danny Gleckler <[email protected]>
dlockhart
commented
Aug 10, 2023
| @@ -18,5 +18,7 @@ jobs: | |||
| run: npm run lint:eslint | |||
There was a problem hiding this comment.
I'll hold off merging this until this gets in and I can update this script accordingly.
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get this repo into a more modern state so it can receive active development. This switches it to use
@brightspace-ui/testingas its runner.After this, I'm going to move one Labs component into here just so that "components" has a presence. At that point I'll use the new vdiff stuff.