-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to @brightspace-ui/testing #96
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,62 +12,39 @@ Install from NPM: | |
npm install @brightspace-ui/labs | ||
``` | ||
|
||
## README Index | ||
|
||
|
||
## Developing, Testing and Contributing | ||
## Developing and Contributing | ||
|
||
After cloning the repo, run `npm install` to install dependencies. | ||
|
||
### Linting | ||
|
||
```shell | ||
# eslint and stylelint | ||
npm run lint | ||
|
||
# eslint only | ||
npm run lint:eslint | ||
|
||
# stylelint only | ||
npm run lint:style | ||
``` | ||
|
||
### Testing | ||
|
||
To run the full suite of tests: | ||
|
||
```shell | ||
# lint & run headless unit tests | ||
npm test | ||
|
||
# unit tests only | ||
npm run test:headless | ||
|
||
# debug or run a subset of local unit tests | ||
npm run test:headless:watch | ||
``` | ||
|
||
### Visual Diff Testing | ||
|
||
This repo uses the [@brightspace-ui/visual-diff utility](https://github.com/BrightspaceUI/visual-diff/) to compare current snapshots against a set of golden snapshots stored in source control. | ||
Alternatively, tests can be selectively run: | ||
|
||
The golden snapshots in source control must be updated by the [visual-diff GitHub Action](https://github.com/BrightspaceUI/actions/tree/main/visual-diff). If a pull request results in visual differences, a draft pull request with the new goldens will automatically be opened against its branch. | ||
```shell | ||
# eslint | ||
npm run lint:eslint | ||
|
||
To run the tests locally to help troubleshoot or develop new tests, first install these dependencies: | ||
# stylelint | ||
npm run lint:style | ||
|
||
```shell | ||
npm install @brightspace-ui/visual-diff@X mocha@Y puppeteer@Z --no-save | ||
# unit tests | ||
npm run test:unit | ||
``` | ||
|
||
Replace `X`, `Y` and `Z` with [the current versions](https://github.com/BrightspaceUI/actions/tree/main/visual-diff#current-dependency-versions) the action is using. | ||
|
||
Then run the tests: | ||
This repo uses [@brightspace-ui/testing](https://github.com/BrightspaceUI/testing)'s vdiff command to perform visual regression testing: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Technically this isn't true (yet). |
||
|
||
```shell | ||
# run visual-diff tests | ||
npx mocha './test/**/*.visual-diff.js' -t 10000 | ||
# subset of visual-diff tests: | ||
npx mocha './test/**/*.visual-diff.js' -t 10000 -g some-pattern | ||
# update visual-diff goldens | ||
npx mocha './test/**/*.visual-diff.js' -t 10000 --golden | ||
# vdiff | ||
npm run test:vdiff | ||
|
||
# re-generate goldens | ||
npm run test:vdiff -- --golden | ||
dlockhart marked this conversation as resolved.
Show resolved
Hide resolved
|
||
``` | ||
|
||
### Running the demos | ||
|
@@ -78,41 +55,8 @@ To start a [@web/dev-server](https://modern-web.dev/docs/dev-server/overview/) t | |
npm start | ||
``` | ||
|
||
## Versioning & Releasing | ||
|
||
> TL;DR: Commits prefixed with `fix:` and `feat:` will trigger patch and minor releases when merged to `main`. Read on for more details... | ||
|
||
The [semantic-release GitHub Action](https://github.com/BrightspaceUI/actions/tree/main/semantic-release) is called from the `release.yml` GitHub Action workflow to handle version changes and releasing. | ||
|
||
### Version Changes | ||
|
||
All version changes should obey [semantic versioning](https://semver.org/) rules: | ||
1. **MAJOR** version when you make incompatible API changes, | ||
2. **MINOR** version when you add functionality in a backwards compatible manner, and | ||
3. **PATCH** version when you make backwards compatible bug fixes. | ||
|
||
The next version number will be determined from the commit messages since the previous release. Our semantic-release configuration uses the [Angular convention](https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog-angular) when analyzing commits: | ||
* Commits which are prefixed with `fix:` or `perf:` will trigger a `patch` release. Example: `fix: validate input before using` | ||
* Commits which are prefixed with `feat:` will trigger a `minor` release. Example: `feat: add toggle() method` | ||
* To trigger a MAJOR release, include `BREAKING CHANGE:` with a space or two newlines in the footer of the commit message | ||
* Other suggested prefixes which will **NOT** trigger a release: `build:`, `ci:`, `docs:`, `style:`, `refactor:` and `test:`. Example: `docs: adding README for new component` | ||
|
||
To revert a change, add the `revert:` prefix to the original commit message. This will cause the reverted change to be omitted from the release notes. Example: `revert: fix: validate input before using`. | ||
|
||
### Releases | ||
|
||
When a release is triggered, it will: | ||
* Update the version in `package.json` | ||
* Tag the commit | ||
* Create a GitHub release (including release notes) | ||
* Deploy a new package to NPM | ||
|
||
### Releasing from Maintenance Branches | ||
|
||
Occasionally you'll want to backport a feature or bug fix to an older release. `semantic-release` refers to these as [maintenance branches](https://semantic-release.gitbook.io/semantic-release/usage/workflow-configuration#maintenance-branches). | ||
### Versioning and Releasing | ||
|
||
Maintenance branch names should be of the form: `+([0-9])?(.{+([0-9]),x}).x`. | ||
This repo is configured to use `semantic-release`. Commits prefixed with `fix:` and `feat:` will trigger patch and minor releases when merged to `main`. | ||
|
||
Regular expressions are complicated, but this essentially means branch names should look like: | ||
* `1.15.x` for patch releases on top of the `1.15` release (after version `1.16` exists) | ||
* `2.x` for feature releases on top of the `2` release (after version `3` exists) | ||
To learn how to create major releases and release from maintenance branches, refer to the [semantic-release GitHub Action](https://github.com/BrightspaceUI/actions/tree/main/semantic-release) documentation. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't do anything since there are no tests, so removing it temporarily.