Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created consensus.go_util.go and edited consensuscore,rpc and types … #51

Conversation

DarkLord017
Copy link

  • I added some structs in types as in geth many fields were private and was different from alloy(from which helios was importing)
  • in RPC Just edited a type for more correct usage
  • In consensus_core made all public and implemented not implemented fields
  • Wrote consensus/consensus.go and consensus/utils.go
  • Previous PR issues have been resolved and are in this PR so please check
  • Also made a single array of bytes in utils for easy transformation from structs to byte array

@DarkLord017 DarkLord017 marked this pull request as draft September 21, 2024 09:40
@DarkLord017 DarkLord017 marked this pull request as ready for review September 21, 2024 11:19
@DarkLord017
Copy link
Author

@star-gazer111 please review

@DarkLord017 DarkLord017 mentioned this pull request Sep 21, 2024
@star-gazer111
Copy link
Member

@DarkLord017 u were supposed to create a new utils.go in the utils folder that contains all the functions of the currently existing three different utils.go and remove the existing ones.

@DarkLord017
Copy link
Author

DarkLord017 commented Sep 21, 2024

I'm creating that one consensus me time lag gaya
Pehle vo PR daalu fir ye pr daalu kya sir ?
Sorry mujhe laga vo iske baad krna tha 🥲

@star-gazer111
Copy link
Member

I'm creating that one consensus me time lag gaya Pehle vo PR daalu fir ye pr daalu kya sir ? Sorry mujhe laga vo iske baad krna tha 🥲

What does this PR exactly does and which issue does it solves can u please reference?

@DarkLord017
Copy link
Author

I'm creating that one consensus me time lag gaya Pehle vo PR daalu fir ye pr daalu kya sir ? Sorry mujhe laga vo iske baad krna tha 🥲

What does this PR exactly does and which issue does it solves can u please reference?

It solves #24 and also the changes of the previous PR #41

@star-gazer111
Copy link
Member

I'm creating that one consensus me time lag gaya Pehle vo PR daalu fir ye pr daalu kya sir ? Sorry mujhe laga vo iske baad krna tha 🥲

What does this PR exactly does and which issue does it solves can u please reference?

It solves #24 and also the changes of the previous PR #41

Okay thanks.
Also the one error in linter that's coming bcz of a function not being used in merkleproof.go. Where will this function which is unused for now be used in future?

@DarkLord017
Copy link
Author

I'll check n tell u

@DarkLord017
Copy link
Author

@star-gazer111 wait verify merkle proof vo use karke hi likh Deta

@DarkLord017 DarkLord017 marked this pull request as draft September 21, 2024 12:45
Using index too for merkle proof validation
@DarkLord017 DarkLord017 marked this pull request as ready for review September 21, 2024 13:05
@DarkLord017
Copy link
Author

@star-gazer111 sir merkle tree library use karke kar liya utils me but vo function use mr nhi liya kyuki usme index ke bina hi validation ho rha

common/types.go Show resolved Hide resolved
consensus/consensus.go Show resolved Hide resolved
consensus/consensus.go Show resolved Hide resolved
consensus/consensus.go Outdated Show resolved Hide resolved
consensus/consensus.go Show resolved Hide resolved
consensus/consensus.go Show resolved Hide resolved
consensus/consensus.go Outdated Show resolved Hide resolved
consensus/consensus.go Outdated Show resolved Hide resolved
consensus/consensus.go Show resolved Hide resolved
consensus/consensus.go Show resolved Hide resolved
@DarkLord017 DarkLord017 marked this pull request as draft September 21, 2024 15:43
@DarkLord017 DarkLord017 marked this pull request as ready for review September 21, 2024 15:46
@star-gazer111 star-gazer111 merged commit a41942c into BlocSoc-iitr:dev Sep 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants