Created utils.go #41
Closed
Created utils.go #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Implemented consensus/utils.go & corrected consensus/rpc & consensus/consensus_core.go Please check the functions in utils.go |
|
@star-gazer111 sir consensus_core me kuch chize implemented nahi hai to usme changes krdiye hai aur public bhi krdiya hai |
star-gazer111
requested changes
Sep 20, 2024
consensus/utils.go
Outdated
Comment on lines
16
to
28
| type Forks struct { | ||
| Genesis ForkVersion | ||
| Altair ForkVersion | ||
| Bellatrix ForkVersion | ||
| Capella ForkVersion | ||
| Deneb ForkVersion | ||
| } | ||
|
|
||
| type ForkVersion struct { | ||
| Epoch uint64 | ||
| ForkVersion [4]byte | ||
| } | ||
|
|
There was a problem hiding this comment.
this stuff is already implemented here. Why are you reimplementing the same stuff?
|
Please refer to PR #51 |
|
@DarkLord017 this PR is for? |
|
It is already merged (it was for consensus/utils.go) refer #51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check all the functions