Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates modal timeout to 10m #908

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Updates modal timeout to 10m #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d3538e
Updates modal timeout to 10m
beastoin Sep 22, 2024
4367809
Merge branch 'main' into mazebiwh_modal_timeout_10m
beastoin Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
memory=(512, 1024),
cpu=2,
allow_concurrent_inputs=10,
timeout=60 * 19,
timeout=60 * 10,
)
@asgi_app()
def api():
Expand Down
2 changes: 1 addition & 1 deletion backend/routers/transcribe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ async def _websocket_util(
loop = asyncio.get_event_loop()

# Soft timeout, should < MODAL_TIME_OUT - 3m
timeout_seconds = 1800 # 30m
timeout_seconds = 420 # 7m
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description Entelligence.AI

The timeout value has been reduced from 30 minutes to 7 minutes. This is a significant reduction and could potentially lead to premature timeouts if the operations being performed are time-consuming. Please ensure that this new timeout value is sufficient for all expected use cases. If there's a specific reason for this change, it would be beneficial to document it in a comment for future reference.

started_at = time.time()

def stream_transcript(segments, stream_id):
Expand Down
Loading