Updates modal timeout to 10m #908
Conversation
|
WalkthroughThe changes primarily focus on adjusting timeout values in the backend configuration and Changes
Uplevel your code reviews with Entelligence.AI ProEntelligence.AI ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, Entelligence.AI Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (2)
- backend/main.py (1)
- backend/routers/transcribe.py (1)
Files skipped from review due to trivial changes (1)
- backend/main.py
Review comments generated (1)
- Review: 1
- LGTM: 0
Tips
Chat with Entelligence.AI Bot (@Entelligence.AI)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@Entelligence.AIin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@Entelligence.AI: ignoreanywhere in the PR description to pause further reviews from the bot.
| @@ -132,7 +132,7 @@ async def _websocket_util( | |||
| loop = asyncio.get_event_loop() | |||
|
|
|||
| # Soft timeout, should < MODAL_TIME_OUT - 3m | |||
| timeout_seconds = 1800 # 30m | |||
| timeout_seconds = 420 # 7m | |||
There was a problem hiding this comment.
The timeout value has been reduced from 30 minutes to 7 minutes. This is a significant reduction and could potentially lead to premature timeouts if the operations being performed are time-consuming. Please ensure that this new timeout value is sufficient for all expected use cases. If there's a specific reason for this change, it would be beneficial to document it in a comment for future reference.
Summary by Entelligence.AI
_websocket_utilfunction to improve system performance and reliability. The overall timeout value has been reduced from 19 minutes to 10 minutes, and the soft timeout within the_websocket_utilfunction has been decreased from 30 minutes to 7 minutes. These changes aim to enhance the responsiveness of our services and reduce the likelihood of timeouts during heavy load periods.