Revert "CI: disable ccache for MacOS builds" #28952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just checked that an old PR is now fixed. Homebrew or whomever must have fixed the dependency and this should pass. |
it wasn't a dependency issue, ccache was segfaulting |
|
I figured it might be because of something wrong with a dependency because it's working now and its version hasn't changed recently. |
This reverts commit c432716.
peterbarker
force-pushed
the
pr/revert-macosx-build-fix
branch
from
3b377c0 to
3b27ab3
Compare
|
I'm marking this one as MergeOnCIPass on the basis that the segfaulting was probably something bad which github have fixed in their CI. It has already passed CI once, I've force-pushed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c432716.