Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_HAL_ChibiOS: add new target Stellar H7V2 #28926

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

AP_HAL_ChibiOS: add new target Stellar H7V2 #28926

wants to merge 6 commits into from
+1,487 −0

Conversation

cvetaevvitaliy
Copy link
Contributor

add Stellar H7V2 target

@Hwurzburg
Copy link
Collaborator

Needs full readme with images and pinouts...see other recent hwdefs....should break out board id into separate PR that can be merged before this gets a review in order to reserve the board id...also use the text board name instead of number in the hwdefs

@cvetaevvitaliy
Copy link
Contributor Author

Needs full readme with images and pinouts...see other recent hwdefs....should break out board id into separate PR that can be merged before this gets a review in order to reserve the board id...also use the text board name instead of number in the hwdefs

Done

#28929

@cvetaevvitaliy cvetaevvitaliy changed the title add Stellar H7V2 target AP_HAL_ChibiOS: add new target Stellar H7V2 Dec 22, 2024
andyp1per
andyp1per requested changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits need to be squashed per subsystem and labeled according to our coding standards. Please see https://ardupilot.org/dev/docs/submitting-patches-back-to-master.html

libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/hwdef.dat Outdated
define HAL_GPIO_B_LED_PIN 90

# order of UARTs (and USB)
SERIAL_ORDER OTG1 UART7 USART1 USART2 USART3 UART8 UART4 USART6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not recommend changing the order here unless the silkscreen has the same numbering

libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/hwdef.dat Outdated
PD9 USART3_RX USART3
PD8 USART3_TX USART3

# UART4 (spare)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RCIN according to the picture?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UART4

libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/hwdef.dat Outdated
PD3 GPIO_CAN1_SILENT OUTPUT PUSHPULL SPEED_LOW LOW GPIO(70)

# Motors
PB0 TIM3_CH3 TIM3 PWM(1) GPIO(50)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add bidir here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hwurzburg Hwurzburg Awaiting requested review from Hwurzburg

@andyp1per andyp1per Awaiting requested review from andyp1per

Assignees
No one assigned
Labels
NewBoardSupport WikiNeeded needs wiki update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cvetaevvitaliy @Hwurzburg @andyp1per