AP_Scripting: added QUIK_ANGLE_MAX #28890
Open
+39
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
reviewed
Dec 16, 2024
this brings the same protection to the lua script as was added for the C++ implementation
tridge
force-pushed
the
pr-quicktune-angmax
branch
from
de7c058 to
2eb18ae
Compare
IamPete1
reviewed
Dec 18, 2024
| @@ -3761,6 +3761,10 @@ AC_AttitudeControl = {} | |||
| ---@return number -- yaw slew rate | |||
| function AC_AttitudeControl:get_rpy_srate() end | |||
|
|
|||
| -- return current VTOL total attitude error in degrees | |||
There was a problem hiding this comment.
This is only roll and pitch, I wonder if we should just copy the function description exactly from attitude control. That would be:
Return the angle between the target thrust vector and the current thrust vector in degrees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the same attitude error abort protection to the lua VTOL_quicktune script as we have in the C++ version