Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Volz_Protocol: move serial port init of Volz protocol into Volz library #28868

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

peterbarker
Copy link
Contributor

Avoids spreading information about the Volz protocol throughout the serialmanager code.

Board               AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
Durandal                       16     *           16      16                16     16     16
Hitec-Airspeed      0                                                                     
KakuteH7-bdshot                40     *           40      40                40     40     40
MatekF405                      -8     *           0       -8                0      -8     0
Pixhawk1-1M-bdshot             -8                 -8      0                 0      -8     -8
f103-QiotekPeriph   -8                                                                    
f303-Universal      -8                                                                    
iomcu                                                           *                         
revo-mini                      0      *           0       0                 -8     0      0
skyviper-v2450                                    0                                       

@@ -676,6 +672,15 @@ uint32_t AP_SerialManager::find_baudrate(enum SerialProtocol protocol, uint8_t i
return _state->baudrate();
}

void AP_SerialManager::set_default_baud(enum SerialProtocol protocol, uint8_t instance, uint32_t _baud)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be set_and_default_baud. That is exactly the AP Param call. It has both set_default which won't change the current value and set_and_default which does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, fixed.

Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbarker peterbarker merged commit 05e5d2e into ArduPilot:master Dec 16, 2024
99 checks passed
@peterbarker peterbarker deleted the pr/volz-default-baud branch December 17, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants