Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Mount: privatise various fields and methods #28755

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

peterbarker
Copy link
Contributor

We are hoping to pull more target calculations into the frontend.

Having these non-private threatens for calculations to move into the separate backends instead, so privatise them

I'm relying on the autotest suite (compilation...) and inspection for this.

We are hoping to pull more target calculations into the frontend.

Having these non-private threatens for calculations to move into the separate backends instead, so privatise them
Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry to be nitpicky but could you move _yaw_lock to be below the "get_angle_target_to_location()" method? Sorry but I like to have the members below the methods.

otherwise it looks OK to me, txs

@peterbarker peterbarker force-pushed the pr/mount-field-privatise-2 branch from 296a113 to 93c0135 Compare December 16, 2024 08:03
@rmackay9 rmackay9 dismissed their stale review December 16, 2024 10:15

fixed, txs

@rmackay9 rmackay9 merged commit aec7cc2 into ArduPilot:master Dec 16, 2024
99 checks passed
@peterbarker peterbarker deleted the pr/mount-field-privatise-2 branch December 17, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants