Move rudder arming up into RC_Channel library #16091
Open
+216
−348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/rudder-arming-up
branch
3 times, most recently
from
5570908 to
f71ac3b
Compare
peterbarker
force-pushed
the
pr/rudder-arming-up
branch
4 times, most recently
from
e7c327b to
827ff0d
Compare
peterbarker
force-pushed
the
pr/rudder-arming-up
branch
from
827ff0d to
8bc7e33
Compare
peterbarker
force-pushed
the
pr/rudder-arming-up
branch
from
8bc7e33 to
65df351
Compare
peterbarker
force-pushed
the
pr/rudder-arming-up
branch
2 times, most recently
from
157f4c3 to
9ef65ee
Compare
peterbarker
force-pushed
the
pr/rudder-arming-up
branch
from
9ef65ee to
24377cf
Compare
|
Tested in SITL - standard arming and RUDDER_DISARM values. |
rmackay9
reviewed
Apr 5, 2021
rmackay9
reviewed
Apr 5, 2021
tridge
requested changes
Apr 5, 2021
peterbarker
force-pushed
the
pr/rudder-arming-up
branch
3 times, most recently
from
ab489a5 to
2815824
Compare
|
@rmackay9 also noted on the call that he's happy for the 10s trim feature to be removed if whoever removes it ensures docs are updated |
|
Docs for autotrim are here: https://ardupilot.org/copter/docs/autotrim.html and here: https://ardupilot.org/copter/docs/arming_the_motors.html. The 2nd link in particular has a warning that could be updated to be clear it only applies to 4.0 (and earlier) |
peterbarker
force-pushed
the
pr/rudder-arming-up
branch
2 times, most recently
from
d5d9ae1 to
2ae574d
Compare
|
This needs testing on a Copter. |
peterbarker
force-pushed
the
pr/rudder-arming-up
branch
from
2ae574d to
28b2f30
Compare
the arm/disarm cases were identical, so reuse the code
It uses this for triggering RC-based ahrs trim. RC_Channel: don't allow rudder arming if no valid RC input
peterbarker
force-pushed
the
pr/rudder-arming-up
branch
from
28b2f30 to
a752133
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make rudder-arming consistent across our vehicles.
One known behaviour change is that the rover arm interval has moved from 2 to 3 seconds (to be like Copter and Plane).