Feature/tooltips offscreen #1412

lawson89 · 2023-10-13T17:32:03Z

Tooltips go off-screen #1224

show up and to the left by calculating width of tooltip window

consolidate code

rdbende

Thanks, I like your simple solution! It works well, but I'll wait for @Akuli to have a look at it, I don't dare to merge it just like that 🙃

porcupine/utils.py

use update_idletasks() instead of update()

rdbende · 2023-10-13T19:26:07Z

btw, the Windows build failure is not related.

Akuli · 2023-10-13T19:58:22Z

This works, but the tooltip looks weird to me when it appears around the middle of the screen.

Maybe center it horizontally (self.mousex - tipwindow.winfo_width()/2) if it fits, and otherwise do like in this PR now?

center tooltip unless tip would go off the screen and then use what screen space is available

Akuli

Thanks!

lawson89 added 2 commits October 13, 2023 13:24

Tooltips go off-screen Akuli#1224

f7757fc

Tooltips go off-screen Akuli#1224

c8b3c57

consolidate code

rdbende requested changes Oct 13, 2023

View reviewed changes

porcupine/utils.py Outdated Show resolved Hide resolved

rdbende linked an issue Oct 13, 2023 that may be closed by this pull request

Tooltips go off-screen #1224

Closed

Tooltips go off-screen Akuli#1224

a3eb36d

use update_idletasks() instead of update()

rdbende approved these changes Oct 13, 2023

View reviewed changes

lawson89 and others added 2 commits October 13, 2023 17:50

Tooltips go off-screen Akuli#1224

8983a69

center tooltip unless tip would go off the screen and then use what screen space is available

Run pycln, pyupgrade, black and isort

cbe2b34

Akuli approved these changes Oct 14, 2023

View reviewed changes

Akuli merged commit 5cb0a87 into Akuli:main Oct 14, 2023

Provide feedback