Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltips go off-screen #1224

Closed
rdbende opened this issue Nov 27, 2022 · 4 comments · Fixed by #1412
Closed

Tooltips go off-screen #1224

rdbende opened this issue Nov 27, 2022 · 4 comments · Fixed by #1412
Labels
good first issue help wanted

Comments

@rdbende
Copy link
Collaborator

rdbende commented Nov 27, 2022

image
@Moosems
Copy link
Contributor

Moosems commented Jun 29, 2023

You can borrow the placement code from DIP's tooltip, I developed it with Akuli so I hope it lives up to his standards.

@Akuli
Copy link
Owner

Akuli commented Jun 29, 2023

yes, I like how simple we eventually got DIP's tooltip logic :)

Though for these tooltips it could be even simpler. We could e.g. always show the tooltip above and to the left, there's always room.

@Moosems
Copy link
Contributor

Moosems commented Jun 29, 2023

Thank you for your help with that by the way, it was tremendously useful.

@lawson89
Copy link
Contributor

I can grab this one - I'll submit a PR by end of day today for review

lawson89 added a commit to lawson89/porcupine that referenced this issue Oct 13, 2023
@lawson89
Tooltips go off-screen Akuli#1224
f7757fc
lawson89 added a commit to lawson89/porcupine that referenced this issue Oct 13, 2023
@lawson89
Tooltips go off-screen Akuli#1224
c8b3c57 
 consolidate code
@lawson89 lawson89 mentioned this issue Oct 13, 2023
Merged
@rdbende rdbende linked a pull request Oct 13, 2023 that will close this issue
Feature/tooltips offscreen #1412
Merged
lawson89 added a commit to lawson89/porcupine that referenced this issue Oct 13, 2023
@lawson89
Tooltips go off-screen Akuli#1224
a3eb36d 
use update_idletasks() instead of update()
lawson89 added a commit to lawson89/porcupine that referenced this issue Oct 13, 2023
@lawson89
Tooltips go off-screen Akuli#1224
8983a69 
center tooltip unless tip would go off the screen and then use what screen space is available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/tooltips offscreen lawson89/porcupine
4 participants
@lawson89 @Akuli @rdbende @Moosems