Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "+" in object queries with "%2B" #260

Merged
merged 2 commits into from
Nov 7, 2014
Merged

Replace "+" in object queries with "%2B" #260

merged 2 commits into from
Nov 7, 2014

Commits on Nov 6, 2014

  1. Replace "+" in object queries with "%2B" 

    This fixes issue AdRoll#259 in which objects with "+" in the
object key cannot be retrieved.
    Donovan Kolbly committed Nov 6, 2014
    Configuration menu
    Copy the full SHA
    6006405 View commit details
    Browse the repository at this point in the history

  2. Added test case for %2B-expansion of "+" in object names 

    It turns out that req.URL is already processed, so it would
come back as "has+plus" both with and without the fix, but req.RequestURI
is not %-expanded so works to verify this fix.
    Donovan Kolbly committed Nov 6, 2014
    Configuration menu
    Copy the full SHA
    ecb71ce View commit details
    Browse the repository at this point in the history