Replace "+" in object queries with "%2B" #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue AdRoll#259 in which objects with "+" in the object key cannot be retrieved.
|
@dkolbly would you please add a test that specifically tests for this change? |
It turns out that req.URL is already processed, so it would come back as "has+plus" both with and without the fix, but req.RequestURI is not %-expanded so works to verify this fix.
|
@alimoeeny done. I had to check RequestURI instead of URL, since URL is already munged at that point and so did not distinguish between the correct and incorrect code. This test fails w/o my patch and succeeds with it. |
alimoeeny
added a commit
that referenced
this pull request
Nov 7, 2014
Replace "+" in object queries with "%2B"
|
Thank you very much @dkolbly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #259 in which objects with "+" in the
object key cannot be retrieved.