Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Esbuild #2112

Closed
wants to merge 15 commits into from
Closed

Esbuild #2112

wants to merge 15 commits into from

Conversation

TheSlimvReal
Copy link
Collaborator

@TheSlimvReal TheSlimvReal commented Nov 29, 2023 •
edited
Loading

See https://angular.io/guide/esbuild#using-the-application-builder

  • flag-icon is not directly supported (ESBuild not possible when using flag-icons lipis/flag-icons#1142) -> fixed by using "outputHashing": "media" in development mode -> has been removed
  • Our parse-xliff-to-js script which is supposed to work in the serve runtime as well as in the build in the Dockerfile has some issues with the new builder
  • The dynamic imports of the angular locale in the main.ts seem to be problematic (at least thats what the console says)

@github-actions GitHub Actions
Copy link

Deployed to https://pr-2112.aam-digital.net/

@TheSlimvReal TheSlimvReal mentioned this pull request Nov 29, 2023
Merged
@TheSlimvReal TheSlimvReal changed the base branch from master to dep_update November 29, 2023 15:48
Base automatically changed from dep_update to master November 29, 2023 15:55
@sleidig sleidig mentioned this pull request Mar 15, 2024
Open
@sleidig sleidig closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheSlimvReal @sleidig