Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates #2107

Merged
merged 14 commits into from
Nov 29, 2023
Merged

Dependency updates #2107

merged 14 commits into from
Nov 29, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

@TheSlimvReal TheSlimvReal commented Nov 28, 2023

All app dependencies updated to latest version.
Also the used Node version has been updated to 18.

There were some issues with the style paths. Maybe this fixes the sometimes broken styles 🤞

Copy link

Deployed to https://pr-2107.aam-digital.net/

@TheSlimvReal TheSlimvReal marked this pull request as draft November 28, 2023 14:02
@TheSlimvReal TheSlimvReal marked this pull request as ready for review November 28, 2023 17:26
@TheSlimvReal TheSlimvReal requested a review from sleidig November 28, 2023 17:27
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to build and work well. Awesome!

Only the icon color for the primary action somehow switched from white to black, although I prefer the look and contrast of white icon. I switched that manually now
image

Any new features or migrations from Angular v17 we should consider? Maybe the new build system? https://angular.io/guide/esbuild

@TheSlimvReal
Copy link
Collaborator Author

@sleidig I was trying the esbuild a little but there are a few issues

  • flag-icon is not directly supported (issue), this can be fixed with output hashing though
  • Our parse-xliff-to-js script which is supposed to work in the serve runtime as well as in the build in the Dockerfile has some issues with the new builder
  • The dynamic imports of the angular locale in the main.ts seem to be problematic (at least thats what the console says)

Feel free to have a look at the #2112 maybe you find fixes to the problems

@TheSlimvReal TheSlimvReal merged commit 7309cd8 into master Nov 29, 2023
8 checks passed
@TheSlimvReal TheSlimvReal deleted the dep_update branch November 29, 2023 15:55
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.26.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released managed by CI (semantic-release)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants