ENH: Max CAPPI

[syedhamidali]

• Closes Constant Altitude Plan Position Indicator (CAPPI) #597
• Tests added
• Examples Added
• Documentation reflects changes: Not sure

So, I have added the plot_maxcappi function to the gridmapdisplay, here is what it is supposed to do

import pyart

grid = pyart.io.read_grid("GRID_KGRR20240119_163853_V06.nc")
display = pyart.graph.GridMapDisplay(grid)

display.plot_maxcappi('reflectivity', vmin=0, vmax=60, add_slogan=True)

[zssherman]

I re-added back in Max as a reviewer as well as he made some change comments on the original PR, I'm reviewing as well.

[zssherman]

Same here, maybe leave it up to the user for plt.show()?

[syedhamidali]

Actually, it doesn't take the fig and ax arguments since its fig canvas (Main, upper, right and colorbar axes) is manually built, that is why. What do you suggest?

[zssherman]

More curiosity, but reason for having the code in its own file and then here as well?

[syedhamidali]

It was a long code, didn't wanted to overcrowd the gridmapdisplay.py script

[syedhamidali]

What do you suggest?

[zssherman]

I think it would be fine being in the gridmapdisplay, or either or, we can get @mgrover1 thoughts on it as well.

[syedhamidali]

I’m open to merging it back if that’s preferred. Let's see what @mgrover1 has to say!

[syedhamidali]

I’ve addressed the major issues causing CI failures. The only one remaining is build-deploy-site / deploy-website. I’m not sure what that involves, so you might need to handle it.

[zssherman]

@syedhamidali No worries on the build doc fail, I have a fix for it in my PR

[mgrover1]

This looks great to me - I like the idea of moving a bulk of it to its own submodule, and it being used with the gridmapdisplay.