Fixes #569 (🐛 Bug) #570
Merged
Fixes #569 (🐛 Bug) #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-thankyou-lin
approved these changes
Nov 21, 2024
|
Hey! Thank you so much for merging my PR. This somehow works when there is nothing competing for the vram We have to add a call to ctypes.pointer when we pass it to the function. This probably also affects the fix on the mujoco repo as well. I've created a second PR #574 Thanks! |
|
I updated this comment because as I noted in the issue #573 this actually didn't cause the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
In python 3.12 the way that ctypes works with PyOpenGL is slightly stricter, meaning that what worked before due to a silent cast now crashes.
This addresses the issue here: #569
How it was tested
Ran the tests (they worked) and also tried the snippet on python 3.12 and 3.11 and it also worked
How to checkout & try? (for the reviewer)
Use python 3.12 and try to use the snippet I mentioned in issue #569