-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating module/robots and module/renderer docs #566
base: master
Are you sure you want to change the base?
Conversation
abhihjoshi
commented
Nov 17, 2024
- Updating documentation for new robot, grippers, and bases
- Updating documentation for renderers including Isaac ray tracing and path tracing capabilities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments, thanks!
docs/modules/renderers.md
Outdated
### Path tracing | ||
![Path tracing](../images/gr1_cereal_path_tracing.png "Path tracing") | ||
|
||
Path tracing typically offers higher quality and is ideal for offline learning. If you have the time to collect data and plan to train algorithms using offline data, we recommend using path tracing for its photorealistic results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you've a sense of the speed to give folks a sense of how long it takes to render things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let me try to get those numbers later today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lmk when to look again
|
||
| Renderer | Estimated FPS | | ||
|----------------|---------------| | ||
| MuJoCo | 80-90 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What image resolution is this for? I remember that for simple scenes and low res (maybe around 256x256?), the mujoco renderer could reach ~2k fps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was for 512x512, I am just using the default values in the demo_video_recording script