Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile python version and dependencies installation #500

Merged
merged 1 commit into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
FROM python:3.7-alpine
FROM python:3.12-alpine

WORKDIR /usr/src/norminette

COPY pyproject.toml poetry.lock ./

RUN pip3 install poetry \
&& poetry config virtualenvs.create false \
&& poetry install --no-dev

COPY . .

RUN pip3 install -r requirements.txt \
&& python3 setup.py install
RUN python3 setup.py install

WORKDIR /code

Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ norminette -dd
```
docker build -t norminette .
cd ~/42/ft_printf
docker run -v $PWD:/code norminette /code
docker run --rm -v $PWD:/code norminette
```

If you encounter an error or an incorrect output, you can:
- Open an issue on github
- Open an issue on github
- Post a message on the dedicated slack channel (#norminette-v3-beta)


Please try to include as much information as possible (the file on which it crashed, etc)

Expand Down
Loading