Fix Dockerfile python version and dependencies installation #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ourobore
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The Docker configuration for running norminette is not working out of the box.
Python is 3.8, but the Docker container was usingPython 3.7.Poetryinstead of a plainrequirements.txtfile (which has been removed, yet still referenced in the Dockerfile).READMEcreates a new container each time, leaving unused containers behind.Solution:
Dockerfileto the latest stable version (3.12).Dockerfileto use Poetry for dependency management.--rmflag to the Docker run command in theREADMEto automatically remove the container after execution.