Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing Symbol.observable typings to build output #168

Merged
merged 2 commits into from
Aug 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fresh-tips-yell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'wonka': patch
---

Add missing `Symbol.observable` global declaration back to typings.
6 changes: 0 additions & 6 deletions src/helpers.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
import { TalkbackFn, TeardownFn, Start, Push, SignalKind } from './types';

declare global {
interface SymbolConstructor {
readonly observable: symbol;
}
}

/** Placeholder {@link TeardownFn | teardown functions} that's a no-op.
* @see {@link TeardownFn} for the definition and usage of teardowns.
* @internal
Expand Down
8 changes: 8 additions & 0 deletions src/observable.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
import { Source, SignalKind, TalkbackKind } from './types';
import { push, start, talkbackPlaceholder, observableSymbol } from './helpers';

// NOTE: This must be placed in an exported file for `rollup-plugin-dts`
// to include it in output typings files
declare global {
interface SymbolConstructor {
readonly observable: symbol;
}
}

/** A definition of the ES Observable Subscription type that is returned by
* {@link Observable.subscribe}
*
Expand Down
Loading