Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing Symbol.observable typings to build output #168

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

kitten
Copy link
Member

@kitten kitten commented Aug 3, 2023

Resolves #167

Summary

This moves back the global Symbol.observable declaration to ensure that rollup-plugin-dts outputs it in the built typings. This also adds a note to ensure it stays intact.

Set of changes

  • Move Symbol.observable declaration back to exported observable.ts

@kitten kitten merged commit f028aa3 into main Aug 3, 2023
1 check passed
@kitten kitten deleted the fix/observable-symbol-typings branch August 3, 2023 10:59
@github-actions github-actions bot mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript errors in wonka 6.3.3
1 participant