Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an add-on, cover ZyteLogFormatter in the docs #127

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Gallaecio
Copy link
Contributor

Follow-up to #126 (comment), with code from #124.

@Gallaecio Gallaecio requested review from kmike and wRAR December 31, 2024 11:10
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 15 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@4350d9b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
zyte_common_items/_addon.py 34.78% 15 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage        ?   96.83%           
=======================================
  Files           ?       65           
  Lines           ?     2400           
  Branches        ?        0           
=======================================
  Hits            ?     2324           
  Misses          ?       76           
  Partials        ?        0           
Files with missing lines Coverage Δ
zyte_common_items/__init__.py 100.00% <100.00%> (ø)
zyte_common_items/log_formatters.py 60.00% <ø> (ø)
zyte_common_items/_addon.py 34.78% <34.78%> (ø)

docs/setup.rst Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants