Kicad KLE plugin RGB support and merge conflicts #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If "${KIPRJMOD}/keyboard-layout.json" exists, will set the file picker path to it.
hksaperstein
changed the title
|
if someone needs to use this commit, while still in PR, follow the original instructions for setting up the plugin and then basically copy this commit to the kle_placer_action.py file in the location of the plugin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took what @AlansCodeLog started wrt auto layout for RGB and addressed merge conflicts and minor execution bugs. I have not tested for specific rotation mode (wasn't too sure how to even set up my keyboard json for it), i did rotate the first switch in kicad and all other switches/components did follow. This also does force the user to use RGB, which is definitely not what is wanted. I have some work on an unpushed commit to use OO to allow for switch/components to be more encapsulated and selected more dynamically, but for now if this lives in a PR, at least another user could pull the commit for their rgb needs.
It also assumes that the footprints of all components have an origin at the center, but according to kicad docs, that seems to be the current standard/expectation anyway. last assumption is that all components start at ref 1, and D and LED are differentiated. Could be future room for selecting range of refs, but i think the component values could be set to LED, plugin executed, and changed back to D with new refs, without messing up the layout.