Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade openai & drop GoogleTranslator #666

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

jokester
Copy link
Contributor

@jokester jokester commented Jul 3, 2024

a recent version is necessary after #645

but it got incorrectly downgraded in #657

GoogleTranslator had to be removed because its dep googletrans blocks upgrade to deps.

a recent version is necessary after zyddnys#645

but it got incorrectly downgraded in zyddnys#657
@jokester jokester marked this pull request as draft July 3, 2024 06:16
@jokester jokester changed the title upgrade openai upgrade openai & drop GoogleTranslator Jul 3, 2024
@jokester
Copy link
Contributor Author

jokester commented Jul 3, 2024

smoke test:

pip install still work : https://github.com/moeflow-com/manga-image-translator/actions/runs/9773183532/job/26978849385

import manga_translator; import manga_translator.translators; still work

@jokester jokester marked this pull request as ready for review July 3, 2024 07:01
@zyddnys zyddnys merged commit 37c209c into zyddnys:main Jul 12, 2024
0 of 2 checks passed
@jokester jokester deleted the fix-openai-version branch July 16, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants