Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ng-auth): fix ngx-auth signature to accept refresh token #25

Conversation

ivan-morandi-zupit
Copy link
Member

Checklist before requesting a review

  • I have performed a self-review of my code
  • Does the code follow the team's coding standards and best practices?
  • Is the code well-organized and easy to understand?
  • Are file, variable and function names clear and meaningful?
  • Are there any duplicated code blocks that can be refactored into reusable functions?

Functionality

  • Does the PR implement the intended functionality or fix the issue described in the title and description?
  • Are there any edge cases that have been overlooked?

Testing

  • Are there sufficient tests covering the changes?
  • Are there any missing test cases that need to be added?
  • Has the code been tested in different environments if applicable (e.g., browsers, platforms, devices)?

Documentation

  • Are the changes well-documented and easy to understand?
  • Are there any missing or outdated comments in the code?
  • Is the PR title clear and detailed enough to provide necessary context?

Performance

  • Do the changes have any impact on the system's performance?
  • Are there any potential bottlenecks that need to be addressed?

Dependencies

  • Have the changes introduced any new dependencies or updated existing ones?
  • Are the dependencies up-to-date and secure?

Compatibility

  • Will the changes have any adverse effects on other parts of the system?
  • Do they work well with other existing features?

Continuous Integration/Deployment (CI/CD)

  • Have the changes passed the CI/CD pipeline?
  • Are there any deployment considerations or steps that need to be taken into account?

Code Review language

  • Is the feedback provided in a constructive and respectful manner?
  • Has the reviewer avoided personal attacks or harsh language?
  • Are there any suggestions for improvement or alternative approaches?

@nx-cloud
Copy link

nx-cloud bot commented Oct 9, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b8ad9a2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


⌛ The following targets are in progress

✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

Copy link
Member

@alessio-libardi-zupit alessio-libardi-zupit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful, you'll need to correctly cherry-pick the commit from main, otherwise in the future there could be potentials mismatch git is not able to fix.

@ivan-morandi-zupit ivan-morandi-zupit force-pushed the fix/update-ngx-auth-service-to-accept-new-signature branch from 2054a13 to bfab688 Compare October 9, 2023 09:11
auto-merge was automatically disabled October 9, 2023 09:12

Pull request was closed

@ivan-morandi-zupit ivan-morandi-zupit force-pushed the fix/update-ngx-auth-service-to-accept-new-signature branch from bfab688 to b8ad9a2 Compare October 9, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants