Skip to content

Commit

Permalink
Add DISABLE_V8_COMPILE_CACHE flag to fix build failure
Browse files Browse the repository at this point in the history
**Description**

* Add DISABLE_V8_COMPILE_CACHE flag to fix build failure

**Motivation**

* Seeing error below while building package with nodejs 20:

```
Error: Command failed: yarn list --prod --json

 Fatal error in , line 0
 Check failed: current == end_slot_index.
```

* Per recommendation in nodejs/node#51555,
  setting this flag

**Testing Done**

* Dry-run building this package after setting this flag. The error no
  longer shows up.

**Backwards Compatibility Criteria (if any)**

* N/A
  • Loading branch information
Zuoyuan Huang committed Jun 23, 2024
1 parent 8f872b3 commit 7bf14f5
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions recipe/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ set -exuo pipefail
pushd sagemaker-code-editor
pushd src

# Fix error 'Check failed: current == end_slot_index.' while running 'yarn list --prod --json'
# in nodejs 20.x
# See https://github.com/nodejs/node/issues/51555
export DISABLE_V8_COMPILE_CACHE=1

# Install node-gyp globally as a fix for NodeJS 18.18.2 https://github.com/microsoft/vscode/issues/194665
npm i -g node-gyp

Expand Down

0 comments on commit 7bf14f5

Please sign in to comment.